additional piece of nsRuleNode::ComputeDisplayData should have been removed

RESOLVED FIXED in mozilla1.9.1b2

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.9.1b2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

While looking at bug 460012, I noticed that an additional piece of nsRuleNode::ComputeDisplayData should have been removed.  The chunk at the beginning that always ensures a real parentDisplay was there so that the chunk removed in bug 238072 had a correct parentDisplay.  It's harmless, but no longer needed.
(Assignee)

Comment 1

10 years ago
Created attachment 343234 [details] [diff] [review]
patch
Attachment #343234 - Flags: superreview?(bzbarsky)
Attachment #343234 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

10 years ago
The code being removed was introduced in bug 171749 and refactored in bug 332333.
Attachment #343234 - Flags: superreview?(bzbarsky)
Attachment #343234 - Flags: superreview+
Attachment #343234 - Flags: review?(bzbarsky)
Attachment #343234 - Flags: review+
(Assignee)

Comment 3

10 years ago
Fixed: http://hg.mozilla.org/mozilla-central/rev/30df17ed7d7f
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.