460070 - about:sessionrestore should not be affected by 3rd party themes

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[WildcatRay]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081015 Minefield/3.1b2pre Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081015 Minefield/3.1b2pre Firefox/3.0.3

For a customizable product such as Firefox, a critical feature like the session restore after a browser crash page (about:sessionrestore) should not be affected by third party themes.

Link to about:sessionrestore as it appears with the Qute 3.3.7 theme installed on Minefield:

http://img80.imageshack.us/my.php?image=sesrestbadti8.jpg

Link to about:sessionrestore as it appears with the default theme on Minefield:

http://img205.imageshack.us/my.php?image=sesrestvw1.jpg

Reproducible: Always

Steps to Reproduce:
1. Install a 3rd party theme like Qute 3.3.7. in Minefield or Firefox 3.1 beta with the new session retore feature.
2. Enter about:sessionrestore in address (url) bar and press Enter key.
Actual Results:  
See first image link in Details above.

Expected Results:  
See second image link in Details above.

My concern in posting this bug is that a critical feature such as session restore should not be affected by a 3rd party theme. By forcing the user to have to switch to the default theme and then restarting the browser may result in the user losing the session they need/want to restore which would seem to defeat the purpose of having a session restore function.

Also, this would seem to introduce another factor(s) that 3rd party theme authors will now need to address. One would think this should not be the preferred course of action for a product with a key feature of it's user customization capability.

Comment 1

[Simon Bünzli]

FYI: You're using a theme which isn't compatible with the latest Minefield nightlies - and that can have all kinds of consequences.

Themes have always had to be adjusted for new features - and this is no exception. Sounds like an INVALID bug to me.

Comment 2

[Dão Gottwald [:dao]]

This bug would be valid if browser/themes/*/browser/aboutSessionRestore.css would contain behavioral rather than presentational CSS, but I don't see anything critical there.