460119 - Convert autocomplete feedback increase to an async query

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

Feedback increase on autocomplete selection can be done async, the only draawback is that we need to change the test to poll the db for the actual input change. so in 
  nsNavHistory::AutoCompleteFeedback
do
  nsCOMPtr<mozIStoragePendingStatement> canceler;
  rv = statement->ExecuteAsync(nsnull, getter_AddRefs(canceler));

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch

the biggest change is the test, as discussed on IRC i'm polling the db every 100ms to see if all data have been written. This is somehow complex but should work, i did not get any test fail with this patch. We will most likely have to update the test if the rank calculation algo changes.

Comment 2

[Marco Bonardo [:mak]]

oh, the scope is not locking the UI when a user chooses an item from the autocomplete dropdown.

patch built upon fsync stuff, will not apply cleanly on actual tree

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 343405 [details] [diff] [review]
patch

looks good, r=me. however, it looks like the only dependency on fsync code is the query to confirm use-count updates. if that's so, then please change that so we can land this now. and then update the test in the fsync patch.

Comment 4

[Marco Bonardo [:mak]]

(In reply to comment #3)
> (From update of attachment 343405 [details] [diff] [review])
> looks good, r=me. however, it looks like the only dependency on fsync code is
> the query to confirm use-count updates. if that's so, then please change that
> so we can land this now. and then update the test in the fsync patch.

since fsync is near i'll wait to see, if that is backed out again i'll push this without the temp table, and change it later.

Comment 5

[Marco Bonardo [:mak]]

hwv there is another dependancy on frecency stuff, the feedback increase function has changes as part of the Ts cleanup

Comment 6

[Marco Bonardo [:mak]]

pushed to trunk:
http://hg.mozilla.org/mozilla-central/rev/405b440b26d9

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 343405 [details] [diff] [review]
patch

asking approval 1.9.1

This is another move in the direction of "try to not lock the UI after a user action", patch comes with updated test, medium risk.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 343405 [details] [diff] [review]
patch

a191=beltzner

Comment 9

[Marco Bonardo [:mak]]

Attachment: unbitrot

this is the patch that was pushed (unbitrotted)

Comment 10

[Marco Bonardo [:mak]]

pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c5c023fbd98

Comment 11

[Tracy Walker [:tracy]]

verified per checkin and in-testsuite+

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv