Closed
Bug 460205
Opened 17 years ago
Closed 17 years ago
Certain characters in some languages cause new sumo search indexing to fail
Categories
(support.mozilla.org :: Knowledge Base Software, task)
support.mozilla.org
Knowledge Base Software
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: nkoth, Assigned: nkoth)
References
()
Details
(Whiteboard: sumo_only oldsearch)
Attachments
(1 file)
|
4.47 KB,
patch
|
laura
:
review+
ecooper
:
review+
|
Details | Diff | Splinter Review |
The languages are (Korean, Finnish, Polish, Russian, Slovak,
Ukrainian, Japanese).
| Assignee | ||
Comment 1•17 years ago
|
||
Proposed solution: write a logging system that finds out which characters these are whenever it crashes and to exclude them from indexing using a filter
But to check upstream (Sphinx). Laura, did you say you have a contact with someone.
Target Milestone: --- → 0.7.2
Updated•17 years ago
|
Assignee: nobody → laura
| Assignee | ||
Comment 3•17 years ago
|
||
After upgrading to Sphinx 0.9.8.1 and testing this on my dev server, it seems to affect other languages as well (but English is fine). Could this be more to do with the writing out of the XML files/server config of some sort?
To reproduce this problem, edit scripts/sphinx/indexer.php, change the AND tiki_pages.`lang` IN filter in the MySQL query, and then generate the XML by running this.
(There is also UI in tiki-admin_newsearch.php that triggers the indexing.)
| Assignee | ||
Comment 4•17 years ago
|
||
Can others who have a development environment reproduce this?
Updated•17 years ago
|
Target Milestone: 0.7.3 → 0.8
| Assignee | ||
Comment 5•17 years ago
|
||
Update: I seem to have overcome this by making sure every single thing (tags were left out) are being utf8_encode
Now to see if we can search for these international documents...
Assignee: laura → nelson
| Assignee | ||
Comment 6•17 years ago
|
||
This fixes it for me, but can others check as well?
The way to trigger a manual indexing: https://bugzilla.mozilla.org/show_bug.cgi?id=464851#c6
The test case I used: searched for 安装 in Simplified Chinese. You should be getting a list of chinese articles with that, followed by a list of english forum threads with "installation" in them. 安装 means "installation.
Sometimes (notably when I paste the search terms into the search box and press enter instead of using the submit button) I get garbled text in the search results. That might be a separate bug... but if anyone knows why, let me know. (a Firefox bug?)
Attachment #351847 -
Flags: review?(laura)
| Assignee | ||
Updated•17 years ago
|
Attachment #351847 -
Flags: review?(smirkingsisyphus)
Updated•17 years ago
|
Attachment #351847 -
Flags: review?(laura) → review+
Comment 7•17 years ago
|
||
I don't have the permissions to grant reviews yet, but applying the patch and re-indexing works as it should.
To test, I searched for "のカスタマイズ" in Japanese and proper results for Japanese and English (customization/customizing).
Updated•17 years ago
|
Attachment #351847 -
Flags: review?(smirkingsisyphus) → review+
| Assignee | ||
Comment 8•17 years ago
|
||
in r20605/r20606
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Whiteboard: sumo_only oldsearch
You need to log in
before you can comment on or make changes to this bug.
Description
•