460210 - Various frames should call GetMatrixPropagation() instead of using mPropagateTransform

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Craig Topper]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081012 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081012 Minefield/3.1b2pre

nsSVGUseFrame inherits from nsSVGGFrame. nsSVGGFrame contains a field called mPropagateTransform, but never uses it. The place in nsSVGGFrame where it used to be used now calls GetMatrixPropagation().

Unfortunately nsSVGUseFrame is still using mPropagateTransform which it inheritted from nsSVGGFrame. There are no methods in nsSVGGFrame or nsSVGUseFrame to change this field. This field should be removed from nsSVGGFrame. nsSVGUseFrame should then call the GetMatrixPropagation it inherits.

I don't know enough about SVG to know what this would break. I found it by inspection of the code.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Craig Topper]

Attachment: Patch to do what the bugs says

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

There are more problems than in the original patch. Most of this patch was originally in bug 459512.

Comment 3

[Robert Longson [:longsonr]]

Thanks for raising the bug Craig. There was nothing wrong with what you did except that other classes have the same problem and I already had a patch to fix them all in a bug that's now being used for something else.

Comment 4

[Robert Longson [:longsonr]]

checked in 8554e41d2b04