460233 - Allow switching between new and old sumo search depending on admin parameter

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Nelson Ko [:nkoth]]

Need to direct current search box to the new sumo search instead of the existing one in the presence of a specific query string var

Comment 1

[Laura Thomson :laura]

Also needs an admin UI to allow enable/disable new search.

Comment 2

[Nelson Ko [:nkoth]]

Right now, to use the new search, you need to manually enter queries into tiki-newsearch.php

There is no way to use the existing search boxes (main screen), and search module on right column.

We want an admin setting in the TikiWiki admin panel to switch between using Original search (current) and Sphinx search (new).

This switch will make the search boxes use tiki-newsearch.php instead.

(The uery string part was just an idea to use the new search). On second thoughts, maybe query string var is not the best way to implement this, as just template modifications might work.

Comment 3

[Nelson Ko [:nkoth]]

Actually, the query string part might come in useful in testing. So that it is possible to override the admin setting  to test the new search , without actually having to change the admin setting (which will affect all users).

Can you do that also?

> (The uery string part was just an idea to use the new search). On second
> thoughts, maybe query string var is not the best way to implement this, as just
> template modifications might work.

Comment 4

[E. Cooper [:ecooper]]

Attachment: Ability to use tiki-newsearch.php from search boxes

The on/off switch is a pref set in tiki-admin_newsearch.php. Turning it on, will make it active in all searchlogo search boxes, which are the searches with the Firefox graphics around them.

The optional query string used to call the new search version of the search box happens with "&ns=y". This has to be specified and loaded by the page with the search box.

Comment 5

[Nelson Ko [:nkoth]]

This patch seems to make the search box on the forum pages not appear. e.g. at tiki-forums.php. Does it affect you too?

Comment 6

[E. Cooper [:ecooper]]

Attachment: Search on forums with newsearch flag on

Hmm...It works for me.

Entering a search will take you to tiki-newsearch with &where=f.

Comment 7

[E. Cooper [:ecooper]]

The only why that it won't be showing up is that if it's not called from templates/styles/mozfr/tiki.tpl (it's a static call, so that shouldn't happen) or if there's a syntax error in searchbar.tpl...but if that were the case it shouldn't be appearing anywhere.

Comment 8

[Nelson Ko [:nkoth]]

it seems to have resolved itself for me - maybe it is a smarty cache problem or something.

(In reply to comment #7)
> The only why that it won't be showing up is that if it's not called from
> templates/styles/mozfr/tiki.tpl (it's a static call, so that shouldn't happen)
> or if there's a syntax error in searchbar.tpl...but if that were the case it
> shouldn't be appearing anywhere.

Comment 9

[Nelson Ko [:nkoth]]

Comment on attachment 349807 [details] [diff] [review]
Ability to use tiki-newsearch.php from search boxes

in r20226/r20227

Comment 10

[David Tenser [:djst]]

Does this mean this bug is fixed?

Comment 11

[E. Cooper [:ecooper]]

It just occurred to me that the changes won't apply to the sidebar search box. It's a module, and it doesn't seem to be anywhere in my dev instance. If someone can point me in the right direction, I can make the needed changes to that as well.

Comment 12

[E. Cooper [:ecooper]]

Can someone with admin access on support-stage make sure to turn on the new search from tiki-newsearch.php?

The switch for it is on the very top of the page.

Comment 13

[Nelson Ko [:nkoth]]

Comment on attachment 349807 [details] [diff] [review]
Ability to use tiki-newsearch.php from search boxes

in r20226/r20227

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; http://support-stage.mozilla.org/tiki-admin_newsearch.php?redirect_to_newsearch=on leads searches to run on http://support-stage.mozilla.org/tiki-newsearch.php?locale=en-US&q=clearing&sa= (and return no results due to bug 464851.