460305 - Add ability to run .abc files directly (no compilation) to runtests.py testconfig file.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Chris Peyer]

Currently, the buildbot acceptance test runs delete all .abc files before recompiling and then running the .as files.

This is due to the mops.as test checkin (tamarin-redux: 1005:56691cf41db3) which can not be compiled by the current asc.jar.  This requires the .abc to be run without compilation.

Currently only applies to Tamarin-Redux.

Comment 1

[Chris Peyer]

Correction: mops checkin was 1004:e9e705244c92

Notes from dan schaffer:
I was thinking we could just add a special setting to not recompile the test.  Either create mops.nocompile or make a setting in mops.args.  There are two places in runtests.py to fix.  1) --rebuild would not delete mops.abc and not attempt to rebuild mops.as 2) -f would not try to rebuild mops.as.

Comment 2

[Edwin Smith]

could just rename mops.abc to something else, like mops.abckeep.  the vm doesn't care what the file extension is, afaik

Comment 3

[Brent Baker]

Might be easiest to just:
- rename mops.abc to mops.abc_ (this will no longer be removed on testsuite cleanup)
- add a file called mops.as that is just a dummy shell (need to have something to compile)
- add mops.vm_args to append the mops.abc_ binary to the call to the dummy mops.abc (this will end up running the blank mops.abc and the real test mops.abc_)

This crutch should get it working until the mops opcodes are added into ASC.

Comment 4

[Brent Baker]

Attachment: Get the mops tests working

Pull code from tamarin-tracing that allows you to have a <test.as>.avm_args file that contains additional arguments to pass to the shell when running the test abc file.

This change implements comment #3

Comment 5

[Brent Baker]

Pushed into tamarin-redux as 1012:2e8109418623