Closed Bug 460341 Opened 12 years ago Closed 12 years ago

Re-organize Clear Private Data Dialog

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: johnath, Assigned: johnath)

Details

Attachments

(2 files, 2 obsolete files)

Given that is it passively accumulated as a result of browsing, rather than being the product of independent actions (logging in, filling in forms, saving passwords), it should arguably be under "Browsing History" along with download history. 

This should have the expected checkbox semantics, i.e. checking browsing history should auto-check cache, unchecking browsing history should leave cache to be set or not, per user choice.
Screenshot incoming
Assignee: nobody → johnath
Attachment #344990 - Flags: ui-review?(faaborg)
Attachment #344990 - Flags: review?(mconnor)
Attached image Screenshot with patch (obsolete) —
Checkbox behaviour is as expected
Attachment #344990 - Flags: ui-review?(faaborg)
Attachment #344990 - Flags: review?(mconnor)
Comment on attachment 344990 [details] [diff] [review]
Move Cache under History in the CPD dialog

blah - the hierarchy there sucks - because you want to be able to control them indepedently (what if I don't want my cache cleared, but do want browsing history cleared?)

Arguably better, at that point, to just pull in Alex's overall re-org of the options here.
Summary: Clear Private Data: "Cache" should be under "Browsing History" → Re-organize Clear Private Data Dialog
Attached patch WIP patchSplinter Review
Group the prefs, remove the indent
Attachment #344990 - Attachment is obsolete: true
Attached image Result of WIP
Attachment #344993 - Attachment is obsolete: true
updated design from bug 453440 comment 12:

 |                                                     |
 | History --------------------------------------------|
 |                                                     |
 |  [x] Visited Pages       [ ] Cookies                |
 |  [x] Download List       [ ] Form & Search Entries  |
 |  [x] Web Cache                                      |
 |                                                     |
 |  Remove [ my entire history ]                       |
 |                                                     |
 | Data -----------------------------------------------|
 |  [ ] Saved Passwords     [ ] Offline Website Data   |
 |                                                     |
 |                ( Cancel )  (( Clear Private Data )) |
 '-----------------------------------------------------'

this will be implemented by the patch in that bug.
 |                                                     |
 | History --------------------------------------------|
 |  
     Remove [ my entire history ]  
 |                                                     |
 |  [x] Visited Pages       [ ] Cookies                |
 |  [x] Download List       [ ] Form & Search Entries  |
 |  [x] Web Cache                                      |
 |                                                     |
 |                       |
 |                                                     |
 | Data -----------------------------------------------|
 |  [ ] Saved Passwords     [ ] Offline Website Data   |
 |                                                     |
 |                ( Cancel )  (( Clear Private Data )) |
 '-----------------------------------------------------'

can we go for something like this, apologize for the lack of polish.
Done via combined patch in bug 453440.

http://hg.mozilla.org/mozilla-central/rev/7fc3096ef585
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.