460400 - Shift+Ctrl+A browser keyboard shortcut doesn't execute the browser command (open add-on manager) when an input field has focus

Status: REOPENED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Dão Gottwald [:dao]]

This is from bug 436304:

<key id="key_listAllTabs" key="&listAllTabs.commandkey;" modifiers="accel,shift" oncommand="allTabs.open(true);"/>

&listAllTabs.commandkey; is "a". When an input field or textarea has focus, this selects all instead of executing the above command on Linux. I think this regressed a few months ago.

Comment 1

[Greg]

This bug is a major annoyance. Any chance someone could look into fixing it?

Comment 2

[Paul Silaghi, QA [:pauly]]

Is this still an issue ?

Comment 3

[Paul Silaghi, QA [:pauly]]

Opening addons manager (ctrl-shift-a) works fine to me even if an input field has focus - if that's all about
FF 23b6

Comment 4

[Dão Gottwald [:dao]]

This is still an issue. It's not clear to me where you tested this, this bug was filed for Linux.

Comment 5

[Paul Silaghi, QA [:pauly]]

(In reply to Dão Gottwald [:dao] from comment #4)
> this bug was filed for Linux.
Sorry, I missed that part.
Still an issue in nightly 25.
Narrowing this down I got:
first bad nightly: 2010-09-01 - bug 465900, which is 2 years later after this bug was filled
So, does it still matter what ctrl-shift-a was supposed to do before the shortcut for the addons manager was introduced ?

Comment 6

[Paul Silaghi, QA [:pauly]]

bug 465090 instead of the above one, sorry.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Paul Silaghi [QA] from comment #5)
> So, does it still matter what ctrl-shift-a was supposed to do before the
> shortcut for the addons manager was introduced ?

Yes.

Comment 8

[Paul Silaghi, QA [:pauly]]

Could you please tell me how to test this ? I don't understand what ctrl-shift-a was supposed to do by that time.

Comment 9

[Paul Silaghi, QA [:pauly]]

Or it doesn't matter, should simply not to select all in the field ?

Comment 10

[Dão Gottwald [:dao]]

Yeah, it shouldn't select all text.

Comment 11

[Paul Silaghi, QA [:pauly]]

Unfortunately I couldn't get those old builds (2008-10-16) to start on Ubuntu.

Comment 12

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130725 Firefox/25.0
Build ID: 20130725030212
Built from http://hg.mozilla.org/mozilla-central/rev/a4c1961bf723 (latest nightly)

User Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20130725 Firefox/24.0
Build ID: 20130725004004
Built from http://hg.mozilla.org/releases/mozilla-aurora/rev/f61ece780449(latest Aurora)

User Agent: Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID: 20130722172257
Built from http://hg.mozilla.org/releases/mozilla-beta/rev/8b103274f2d1 (latest release)

Steps to reproduce:
1. Open any website which require text input.
2. Click into the box where text can be entered.
3. Enter some text and keep cursor in the box.
4. Try Shift+Ctrl+A

Expected result:
Entered text in text box should not be selected.

Actual result:
Entered text in text box was not selected for the latest Aurora, beta and nightly.

Comment 13

[Samvedana (:Samvedana)]

Are you still seeing this issue?

Comment 14

[Dão Gottwald [:dao]]

(In reply to Samvedana (:Samvedana) from comment #13)
> Are you still seeing this issue?

You realize that the same question got asked a week ago? :)

This is still an issue. Shift+Ctrl+A should open the add-on manager even if a text field is focused.

Comment 15

[u279076]

Dao, Samvedana was only trying to help.

No one in QA has been able to reproduce this. If you're able to then please find a regression window and add it to this bug. Otherwise I don't see this moving forward.

Comment 16

[Dão Gottwald [:dao]]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #15)
> Dao, Samvedana was only trying to help.
> 
> No one in QA has been able to reproduce this.

Sigh... Paul was able to reproduce it in comment 5.

Comment 17

[u279076]

(In reply to Dão Gottwald [:dao] from comment #16)
> (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #15)
> > Dao, Samvedana was only trying to help.
> > 
> > No one in QA has been able to reproduce this.
> 
> Sigh... Paul was able to reproduce it in comment 5.

My understanding was that Paul could reproduce it before but was having trouble narrowing this down. Maybe you can help with that?

Comment 18

[Dão Gottwald [:dao]]

I'm using Ubuntu too, so if Paul couldn't start those old builds, I probably won't be able to do it either.

Comment 19

[Alice0775 White]

Running on ubuntu12.04LTS + libstdc++5:

I cannot reproduce the problem in
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040207 Firefox/0.8
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040803 Firefox/0.9.3

I can reproduce the problem in
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060410 Firefox/1.0.8
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.12) Gecko/20070508 Firefox/1.5.0.12
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.20) Gecko/20081217 Firefox/2.0.0.20
....
http://hg.mozilla.org/mozilla-central/rev/46d73e889cb4
Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130726 Firefox/25.0 ID:20130726030203

Comment 20

[Dão Gottwald [:dao]]

Thanks Alice. So it look like this bug is older than I originally thought. Not sure if it's worth it or even possible to narrow down the regression range between Firefox 0.9.3 and 1.0.8 to find the change that caused this.

Comment 21

[[:Aleksej]]

Not sure how to reproduce with nightlies which don't have a command on Ctrl+Shift+A.  Text is not selected with 2006-12-16-04-trunk.firefox-3.0a1.en-US.linux-i686, for example.  Per comment #20, removing the rr request

Comment 22

[Liviu Cirdei]

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID 	20160503030421

Works for me on latest Nightly using Ubuntu 15.04. Considering this I will close the bug. If anyone can still reproduce the issue, fell free to reopen it.

Comment 23

[Greg]

@Liviu Cirdei: What version of Firefox is this fixed in? You said it is working in Nightly 11 months ago but you didn't give the exact version. I'm testing this in v52 right now and pressing Ctrl+Shift+A still doesn't work when an input field has focus.

Does this bug need to be reopened, or can we expect the fix to land in v53? v54?

Comment 24

[Greg]

How does one reopen this bug?

Comment 25

[Paul Silaghi, QA [:pauly]]

(In reply to Greg from comment #23)
> I'm testing this in v52 right now and pressing Ctrl+Shift+A still doesn't work
> when an input field has focus.
Hi Greg,
I can't reproduce the issue after I select the input field on google.com and then press Ctrl+Shift+A, Fx 52, Ubuntu 14.04 x64.
Could you please describe your steps and what OS are you using?

Comment 26

[Greg]

Firefox ESR 45.8.0 on Debian 8
-place cursor in URL-bar > press Ctrl+Shift+A = nothing happens
-place cursor in Search-bar > press Ctrl+Shift+A = nothing happens
-place cursor in search box when at Google.com > press Ctrl+Shift+A = nothing happens
-click on open-area to remove cursor from input-field > press Ctrl+Shift+A = Add-ons Manager opens

Firefox 52.0.2 on Ubuntu 16.04 LTS
-place cursor in URL-bar > press Ctrl+Shift+A = nothing happens
-place cursor in Search-bar > press Ctrl+Shift+A = nothing happens
-place cursor in search box when at Google.com > press Ctrl+Shift+A = Add-ons Manager opens
-click on open-area to remove cursor from input-field > press Ctrl+Shift+A = Add-ons Manager opens

Firefox 52.0.1 on Ubuntu 17.04
-place cursor in URL-bar > press Ctrl+Shift+A = nothing happens
-place cursor in Search-bar > press Ctrl+Shift+A = nothing happens
-place cursor in search box when at Google.com > press Ctrl+Shift+A = nothing happens
-click on open-area to remove cursor from input-field > press Ctrl+Shift+A = Add-ons Manager opens

As you can see, I am only able to replicate what you say on Ubuntu 16.04 and only in the Google.com search box.

Comment 27

[Greg]

Is there no way to edit posts/comments? 

x64 on all systems above.

Comment 28

[Paul Silaghi, QA [:pauly]]

(In reply to Greg from comment #26)
> -place cursor in URL-bar > press Ctrl+Shift+A = nothing happens
> -place cursor in Search-bar > press Ctrl+Shift+A = nothing happens
Confirmed on Fx 52, 55.01a (2017-04-14), 45.9.0 ESR, 52.1.0 ESR, Ubuntu 14.04 x64.
Thank you, Greg!

Comment 29

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 30

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Moving all open Keyboard/IME handling bugs to DOM: UI Events & Focus Handling component.

Comment 31

[Amanda Yang]

Attachment: hackkansobanc19769821.txt

Thanks from quiblacwarbu1970.