Replace "undefined" as the first-run tab title with " "

RESOLVED FIXED in Thunderbird 3.0b2

Status

defect
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: gkw, Assigned: gkw)

Tracking

Trunk
Thunderbird 3.0b2
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

11 years ago
Posted image screenshot (obsolete) —
So with the latest nightly binary, when start up on Mac, it shows the account wizard and an "Undefined" tab item.

It should be replaced with something better.

Also, note that suspicious floating icon just below the left and right arrows, which in turn are just below the word "undefined".
Assignee

Comment 1

11 years ago
Bryan, related to thundertab?

if so, this bug should be marked as "depends on" thundertab bug.
Yes, I've seen this too.  I think the best solution would be to always focus the Inbox ( I made comments similar to this in bug 321409 Comment #3 ) on start up such that there never is an 'undefined'
Well, no, since nth10sd's case is "when there is no inbox, no other folder, and no account root, because it's first-run before any account is created." So we either need a word (probably something other than Firefox's "(Untitled)" for a blank tab) or we need to decide that when there is no folder we'll title the tab "". I suspect we'll be sorry later if we use "", since it's such an unlikely case that we'll continue to depend on there always being a current folder name.

(Well, or we could fix it by totally rewriting how first account creation works, but that seems a little excessive.)
ah, I see.  I missed the account wizard, before any accounts are created.  In the mockups I've been using "All Mail" or "Mail" to describe the first tab before it has anything.
Maybe this is obvious but in case it is not: the "undefined" tab title is not localizable and looks really ugly in l10n builds.
You only get one chance to make a first impression, and using an undefined variable isn't a good one.

We just need Bryan to pick a label which doesn't include "Mail" since it not only has no mail in it, but you may not plan on putting any mail in it, if you're firing up Tb for the first time ever to use it as a newsreader or feedreader.
Assignee: nobody → clarkbw
Flags: blocking-thunderbird3+
OS: Mac OS X → All
Hardware: PC → All
Summary: Replace "undefined" with something else → Replace "undefined" as the first-run tab title with something else
I've been thinking "Mail" is actually going to be fine.  I'm not worried that people who are going to use Thunderbird only as a news or feed reader will be terribly confused by seeing the word "Mail" on the tab.  Once their initial account (something other than mail) has been created the tab name will change to show that anyway.
Close enough for rock 'n roll.
Assignee: clarkbw → nobody
Summary: Replace "undefined" as the first-run tab title with something else → Replace "undefined" as the first-run tab title with "Mail"
Just landed bug 429345 which made the title "" when there's no account set up. Personally, I'm not so sure that's not sufficient... Egde case as it is. 

Phil, re comment 3, what case would there ever be when it would be bad/confusing?
The two cases I'm thinking of are assumptions in code that !tab.title always means something bad has happened, or looked at the other way assumptions that tab.title will always be true and have a .length (which it does, except for this one case that we never test, because testing every non-migration patch against a new profile and no-profile first-run while reviewing, much less while patching, is a pain), and the assumption in CSS that .tab-text will always have a width and height, and will never need to worry about things like margin collapse.

Since I'm thinking about it now, when I get to reviewing davida's patch for Mac tabs, I will look at it in a new profile, but two years from now? Might not. Will every single themer? Dunno. Will anyone ever get bitten? Dunno. Is it cheap to avoid? Seems like it to me.

Comment 11

11 years ago
(In reply to comment #10)
> The two cases I'm thinking of are assumptions in code that !tab.title always
> means something bad has happened, or looked at the other way assumptions that
> tab.title will always be true and have a .length

So maybe put there a single space instead of an empty string?
Assignee

Comment 12

11 years ago
Mac theme tabs have also landed, so I guess this bug is now about what word to place in that location instead of an empty string..
Attachment #343516 - Attachment is obsolete: true
Somewhere someone suggested " ", which would fix a lot of Phil's concerns in comment 10.
Assignee

Comment 14

11 years ago
Posted patch patchSplinter Review
simple patch that changes aTab.title to " ".
Assignee: nobody → nth10sd
Status: NEW → ASSIGNED
Attachment #355025 - Flags: review?(mkmelin+mozilla)
Comment on attachment 355025 [details] [diff] [review]
patch

This should do it, though I think I'll bounce it to Phil...
Attachment #355025 - Flags: review?(mkmelin+mozilla) → review?(philringnalda)
Comment on attachment 355025 [details] [diff] [review]
patch

Seems reasonable to me.
Attachment #355025 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/0806ad9a05bd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
Summary: Replace "undefined" as the first-run tab title with "Mail" → Replace "undefined" as the first-run tab title with " "
You need to log in before you can comment on or make changes to this bug.