460469 - Bump gecko MinVersion in application.ini

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabien Tassin]

Today, mobile/app/application.ini shows:

[Gecko]
MinVersion=1.9b5pre
MaxVersion=@GRE_MILESTONE@

When built with gecko 1.9, fennec is totally broken and shows:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 51"  data: no]

This is because of SpatialNavigation only in 1.9.1 so MinVersion should be bumped to 1.9.1something, like 1.9.1b1.

Comment 1

[Fabien Tassin]

Attachment: Bump gecko MinVersion to 1.9.1b1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Technically I think we could run OK with 1.9.1a1pre, since SpatialNavigation.js was renamed in mozilla-central changeset 660805dff89b, when milestone.txt had that value: http://hg.mozilla.org/mozilla-central/annotate/660805dff89b/config/milestone.txt .

We should probably require something newer though, since there were some other improvements in xulrunner that we depend on (at least indirectly). Perhaps we should pick 1.9.1b2pre (the version that's currently on FENNEC_A1_BRANCH)?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> We should probably require something newer though, since there were some other
> improvements in xulrunner that we depend on (at least indirectly). Perhaps we
> should pick 1.9.1b2pre (the version that's currently on FENNEC_A1_BRANCH)?

Yeah, that sounds like a good minimum.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

OK, I bumped it to https://hg.mozilla.org/mobile-browser/rev/cf9a71f37a7c .

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

verified with bata4 we are still OK.