Closed
Bug 460560
Opened 16 years ago
Closed 16 years ago
Escape key doesn't close the Ctrl+Tab panel on Windows
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b2
People
(Reporter: dao, Unassigned)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
888 bytes,
patch
|
Details | Diff | Splinter Review | |
|
1.58 KB,
patch
|
Details | Diff | Splinter Review |
This is due to noautohide="true", added in bug 451300.
Flags: blocking-firefox3.1?
|
Reporter | |
Comment 1•16 years ago
|
||
To fix this, we need to either fix bug 457997 or backout bug 451300.
Depends on: 457997
|
||
Comment 2•16 years ago
|
||
Isn't there a VK_ESCAPE keypress that the panel could catch (in the same handler is uses for VK_TAB and others)?
|
|
Reporter | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Isn't there a VK_ESCAPE keypress that the panel could catch (in the same
> handler is uses for VK_TAB and others)?
We try that, but Ctrl+Esc is handled by Windows.
|
|
||
Comment 4•16 years ago
|
||
So if I'm holding down ctrl and hit escape, what did it used to do? Right now it seems to bring up the start menu which is what I expect. Does ctrl-tab no longer dissappear when you release the control key?
|
|
Reporter | |
Comment 5•16 years ago
|
||
(In reply to comment #4)
> So if I'm holding down ctrl and hit escape, what did it used to do? Right now
> it seems to bring up the start menu which is what I expect.
Yes, and at the same time, the panel should disappear. It doesn't do that because of noautohide="true". noautohide="true" also has other implications, neither of which we want.
> Does ctrl-tab no
> longer dissappear when you release the control key?
It does.
|
|
Reporter | |
Comment 6•16 years ago
|
||
|
|
Reporter | |
Comment 7•16 years ago
|
||
hopefully we won't need this
|
|
||
Comment 9•16 years ago
|
||
The patch for bug 457997 seems to fix this (and removes the autohide from ctrl-tab).
No longer blocks: 463693
|
|
Reporter | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
|
||
Comment 10•16 years ago
|
||
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre ID:20081111032821
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
Flags: blocking-firefox3.1?
|
||
Comment 11•16 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=7433 added to Litmus.
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•