460560 - Escape key doesn't close the Ctrl+Tab panel on Windows

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Dão Gottwald [:dao]]

This is due to noautohide="true", added in bug 451300.

Comment 1

[Dão Gottwald [:dao]]

To fix this, we need to either fix bug 457997 or backout bug 451300.

Comment 2

[Rob Arnold [:robarnold]]

Isn't there a VK_ESCAPE keypress that the panel could catch (in the same handler is uses for VK_TAB and others)?

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> Isn't there a VK_ESCAPE keypress that the panel could catch (in the same
> handler is uses for VK_TAB and others)?

We try that, but Ctrl+Esc is handled by Windows.

Comment 4

[Rob Arnold [:robarnold]]

So if I'm holding down ctrl and hit escape, what did it used to do? Right now it seems to bring up the start menu which is what I expect. Does ctrl-tab no longer dissappear when you release the control key?

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> So if I'm holding down ctrl and hit escape, what did it used to do? Right now
> it seems to bring up the start menu which is what I expect.

Yes, and at the same time, the panel should disappear. It doesn't do that because of noautohide="true". noautohide="true" also has other implications, neither of which we want.

> Does ctrl-tab no
> longer dissappear when you release the control key?

It does.

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch for fixing the panel once bug 457997 is fixed

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch for disabling Aero Glass in case bug 457997 doesn't get fixed

hopefully we won't need this

Comment 9

[Rob Arnold [:robarnold]]

The patch for bug 457997 seems to fix this (and removes the autohide from ctrl-tab).

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre ID:20081111032821

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7433 added to Litmus.