Closed
Bug 460641
Opened 16 years ago
Closed 16 years ago
Cleanup null checking for the folder in nsImapService::StreamMessage
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: rain1, Assigned: rain1)
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
neil
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
The folder null checking's a mess right now. The NS_ENSURE_SUCCESS(rv, rv) seems to be sufficient, as if the folder isn't found, DecomposeImapURI returns with an error. We should fail early, as the folder is required more than ever now. I also took the opportunity to move the ShouldStoreMsgOffline bit down, as it isn't required before that part.
Attachment #343793 -
Flags: superreview?(neil)
Attachment #343793 -
Flags: review?(neil)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 343793 [details] [diff] [review] patch While it looks reasonable to me I'd like bienvenu to double-check that NS_ENSURE_SUCCESS is the right thing to do.
Attachment #343793 -
Flags: superreview?(neil)
Attachment #343793 -
Flags: superreview?(bienvenu)
Attachment #343793 -
Flags: review?(neil)
Attachment #343793 -
Flags: review+
|
||
Comment 2•16 years ago
|
||
Comment on attachment 343793 [details] [diff] [review] patch yes, we can't be streaming an imap message without having an imap folder.
Attachment #343793 -
Flags: superreview?(bienvenu) → superreview+
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → sid1337
|
||
Comment 3•16 years ago
|
||
Checked in, changeset id 642:e08fc2b03467
|
||
Updated•16 years ago
|
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•