Closed Bug 460668 Opened 11 years ago Closed 11 years ago

Remove useless search-sidebar-closebutton from help.xul

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b2

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch Remove close button etc (obsolete) — Splinter Review
When I made Help use the new search textbox, I forgot to remove the old sidebar closebutton. This patch fixes that and tweaks a few strings. Note that we could probably use the emptytext attribute here, but after talking to Neil I rather wait until it's used in seamonkey's search textboxes.

I'll attach a screenshot of how it looks before/after the patch.
Attachment #343815 - Flags: review?(dao)
Attached image Screenshot
Oh, right - forgot to say that I removed some "#helpsidebar-box toolbarbutton" rules in pinstripe that obviously doesn't works since there is no #helpsidebar-box ;)
I always thought it's a bit odd that the search box is on the right, but the search results are on the left of the help window, both labelled as "Search".

How about moving the search-box down and to the left, to the top of the help-sidebar?
(In reply to comment #3)
> I always thought it's a bit odd that the search box is on the right, but the
> search results are on the left of the help window, both labelled as "Search".

That's why I labelled the sidebar header "Search Results" ;)
> 
> How about moving the search-box down and to the left, to the top of the
> help-sidebar?

I don't know... I think the toolbar is the right place for the search-box.
Comment on attachment 343815 [details] [diff] [review]
Remove close button etc

I'll have a new patch up in a few minutes (with emptytext attribute).
Attachment #343815 - Flags: review?(dao)
OK, so this one uses emptytext.
Attachment #343815 - Attachment is obsolete: true
Attachment #344744 - Flags: review?(dao)
Attachment #344744 - Flags: review?(dao) → review?(neil)
Comment on attachment 344744 [details] [diff] [review]
New version with emptytext attribute

dao- (on irc) thought it was better that you looked at this, Neil.
(because you build seamonkey)
Comment on attachment 344744 [details] [diff] [review]
New version with emptytext attribute

Looks like Modern never had a search sidebar closebutton ;-)
Attachment #344744 - Flags: review?(neil) → review+
Pushed changeset 531db9fe7e20 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.