When we call any of these two methods of WindowControl interface
e.g. window.addEventListener("focus", onFocusGained, false))
in the preliminarily loaded page it doesn't work (no events are caught).
Supposed reason: Even support is unimplemented yet, so code must thrown a
updating product, component and setting default owner.
Please attach a concrete minimized testcase that points out the problem here,
Still no testcase here, reassigning to joki who might know why/what/when about
Change component, QA contact and assign to Ed Burns - default module owner for
Reassing to Ed Burns
Reassign to Ashu for investigation.
SetFocus funtion in WindowControl calls into the Mozilla
nsIBaseWindow->SetFocus() function. If there is a disconnect here, it is most
probably because something here was broken in the embedding APIs (that gave
access to nsIBaseWindow object) at the time M16 was released.
RemoveFocus - support for this was removed from M15 onwards. Hence there is no
Embedding API by which this functionality can be exposed to the Webclient users.
I will make this throw an UnImplementedException and check in the change. Will
also follow up with Mozilla Embedding folks to find out if this functionality
might come back later.
Created attachment 14516 [details] [diff] [review]
Proposed patch - diff -u WindowControlImpl.java
I have a temporary patch for this that throws UnImplementedException for these 2
methods. Will check in once I have r=a=edburns.
Checked patch into cvs that throws UnImplementedException. I wont close this Bug
as yet. After we sync up with the PR3 branch, I'll check if this persists...and
only then will I close/work on this bug.
Adding Status white board keyword to track all existing Webclient bugs
Created attachment 25230 [details] [diff] [review]
cvs diff -u of WindowControlImpl.java
I have changed WindowControlImpl.java so that it calls into Native code
(nsIBaseWindow->SetFocus)when SetFocus is called (instead of throwing
UnImplementedException). I have also changed the comment in the Exception
thrown when RemoveFocus is called to indicate that RemoveFocus is no longer
supported by Mozilla. This function does not make much sense anyways
considering that SetFocus is provided to Embedders who wish to have the ability
to TAB through the page being displayed. We should seriously consider removing
this Function from the API.
QA, pls test whether SetFocus works with your API tests using the
Netscape6_0_OEM_Branch mozilla codebase. I know this didn't work with M16.
Ed, do I have ra=edburns for checking this in?
Looks good. r=edburns
SetFocus seems to work and RemoveFocus is no longer supported in Gecko
Embedding. Would the reporter pls verify that the SetFocus works. I am closing
Mark this bug as verified.
Verified with Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.1) Gecko/20010910