460686 - ASSERTION: "Shallow unbind won't clear document and binding parent on kids!" when opening "about:sessionrestore"

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre ID:20081019123054

Following assertion is triggered each time "about:sessionrestore" is opened: 

###!!! ASSERTION: Shallow unbind won't clear document and binding parent on kids!: 'aDeep || (!GetCurrentDoc() && !GetBindingParent())', file /Users/henrik/mozilla/mozilla-central/src/content/base/src/nsGenericElement.cpp, line 2654

Boris, how can I check if its the same issue like bug 397849? Placing a breakpoint to the line where the assertion is raised doesn't stop the execution. How can I obtain the stack? Thanks.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Unfortunately, the stack won't tell you much: it'll just tell you that you're in an element destructor.  That said, placing a breakpoint in NS_DebugBreak_P itself (or just using XPCOM_DEBUG_BREAK=trap) should let you get a stack to the assert..

Comment 2

[Johnny Stenback (:jst)]

Not blocking 1.9.1, but we should get this fixed for a dot release.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: stack

Here the stack for the mentioned assertion. Boris, does it help you?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Not per se, but can you look up which binding we're loading in that LoadBindings call and what node we're attaching it to (presumably XUL, so want the Tag() for it).

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Boris, I hope that I fetched the correct information here.

The mSpec of the URL which is used for the GetBinding call is "chrome://global/content/bindings/tree.xml#treecols". I'm not really sure what you wanna have in the second part of your answer. Where do I have to look for it? Inside GenerateAnonymousContent()? Which variable I have to inspect?

Comment 6

[Boris Zbarsky [:bzbarsky]]

The first argument to LoadBindings() should be an nsIContent.  I'd like to know what concrete type it is (set print object on, then examine the pointer) and what its tagname is (call Tag() on the pointer, and then dig around inside the resulting nsIAtom object).

Comment 7

[Daniel Veditz [:dveditz]]

I think johnny meant wanted1.9.1.x, 1.9.0 doesn't have about:sessionrestore

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Bug 461027 might have fixed this (just landed). Anyone willing to retest this?

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

This is WFM (or fixed) now. If someone can still reproduce, please reopen.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That has been fixed on trunk. Tested with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081221 Minefield/3.2a1pre ID:20081221222459

We have a patch, so marking it fixed.

Smaug, has the patch on bug 461027 also been pushed to mozilla1.9.1? Can you also add it to the depends on list? I cannot access it.