460693 - "trunk" appears twice in query.cgi version list for some combinations of two or more selected components, yielding unexpected query results

Status: NEW

(bugzilla.mozilla.org :: Search, defect, P5)

Description

[Wayne Mery (:wsmwk)]

"trunk" appears twice in query's version list when two components are chosen and one is Mailnews Core. The impact is not severe, but unexpected and the cause is not obvious. Search results shows bugs with version=trunk when one of the "trunks" is deselected. 

This is not a generalized problem however - firefox and core of course bug show trunk when picked individually, but when both are selected trunk is listed only once. This is with bugzilla version 3.2rc1+.

Found attempting to omit trunk version by deselecting "trunk" from the bottom of the version list with two products selected as follows
1. pick advance query https://bugzilla.mozilla.org/query.cgi
2. select products mailnews core and thunderbird
3. in version list trunk appears twice, first after "2.0" at the end of the list
4. select the entire list, deselect either of the trunk items, but not both
5. optionally add other criteria so the results list is manageable - "zone" in summary for example
6. click search
7. click edit search

actual results:
after step 7 both "trunk" items are selected. 

expected results:
no trunk bugs in query result, and only unique items in the version selection list.

likewise, target milestone lists duplicates if several or all products on bmo query page are selected, for example "---" and "Future' appear multiple times

Comment 1

[timeless]

i claim this is either bmo or bugzilla

Comment 2

[Wayne Mery (:wsmwk)]

digging further ... this appears for other components defined in the reorg. For example core graveyard (was that the only other new one?).  In core graveyard's version list "unspecified" also appears at the top of the list, and "Trunk" appears last.

And if you select both components core and core graveyard, then "Trunk" appears twice in the version list. 

So afaict, only Thunderbird is majorly affected.

version isn't the only thing affected per comment 0

Comment 3

[Wayne Mery (:wsmwk)]

another bit which fits actual results of comment 0

1. pick product thunderbird and mailnews core
2. select just *one* "Trunk" under version
3. add other bits to shorten query (restrict changes to one day for example).
4. run query
5. click Edit Search

results:
under version, *both* Trunks are selected

Comment 4

[Wayne Mery (:wsmwk)]

Timeless comment #1)
> i claim this is either bmo or bugzilla

does product mailnews core's versions have sort keys?  

When I select both thunderbird and mailnews - is the problem that version select list isn't rational due to Bug 65317 Versions should have sortkeys like milestones ?

Note: I don't see this when both FF and core are selected.

Comment 5

[Wayne Mery (:wsmwk)]

"there's a bmo-specific horkage on that - don't know if that got fixed - the local JS on bmo was failing to honor the sort keys" justdave quote on IRC

Comment 6

[Gervase Markham [:gerv]]

This is still present, and it's not confined to "Trunk". E.g. select both Toolkit and Toolkit Graveyard, and several entries are repeated. But not all of them - unspecified, for example, is not repeated.

The JavaScript code which populates the box based on the selected products is failing to correctly sort and de-duplicate the list.

Gerv