Closed Bug 460698 Opened 13 years ago Closed 13 years ago

Confusing undocumented code in uninstaller.nsi - un.leaveWelcome

Categories

(Firefox :: Installer, defect)

x86
Windows XP
defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: mcsmurf, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

At http://hg.mozilla.org/mozilla-central/annotate/93111c5c69fd/browser/installer/windows/nsis/uninstaller.nsi#l396 we write "FoundMessageWindow" into $TmpVal. Then we execute a function which does not use or write to $TmpVal and then we change $TmpVal back to "true" again. I think this is not needed.
Also at http://hg.mozilla.org/mozilla-central/annotate/93111c5c69fd/browser/installer/windows/nsis/uninstaller.nsi#l386, maybe a comment would be good to explain where TmpVal gets set (to FoundMessageWindow)?
Summary: Useless StrCpy call in uninstaller.nsi? → Confusing undocumented code in uninstaller.nsi - un.leaveWelcome
Assignee: nobody → robert.bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment only change.

Pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/0e117ce1b61041bd6837fcc87a1add175a50815b

Frank, I added comments to make this less confusing... basically, $TmpVal is used to remember if the message window had previously been found and the user notified to close the app. If it has been found the uninstaller gives the app an additional five seconds to close. If the message window is not found again and there are still files in use $TmpVal is set to true which is used to determine if the uninstaller should display that a restart will likely be required after uninstall.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.