460698 - Confusing undocumented code in uninstaller.nsi - un.leaveWelcome

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

At http://hg.mozilla.org/mozilla-central/annotate/93111c5c69fd/browser/installer/windows/nsis/uninstaller.nsi#l396 we write "FoundMessageWindow" into $TmpVal. Then we execute a function which does not use or write to $TmpVal and then we change $TmpVal back to "true" again. I think this is not needed.
Also at http://hg.mozilla.org/mozilla-central/annotate/93111c5c69fd/browser/installer/windows/nsis/uninstaller.nsi#l386, maybe a comment would be good to explain where TmpVal gets set (to FoundMessageWindow)?

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: comment only patch - checked in

Comment 2

[Robert Strong (they/them - no direct email)]

Comment only change.

Pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/0e117ce1b61041bd6837fcc87a1add175a50815b

Frank, I added comments to make this less confusing... basically, $TmpVal is used to remember if the message window had previously been found and the user notified to close the app. If it has been found the uninstaller gives the app an additional five seconds to close. If the message window is not found again and there are still files in use $TmpVal is set to true which is used to determine if the uninstaller should display that a restart will likely be required after uninstall.