460738 - <video> seems to download/stream from net even if the page has been left through e.g. a link

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Thomas B. Rücker [account mostly dormant]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre

Looks like related to bug 451457

Reproducible: Always

Steps to Reproduce:
1. Go to example URL
2. Leave page through one of the links or put an new URL in the bar and load it.

Actual Results:  
Data still flowing from the net.
(In addition it won't play the same URI in any other page, even a reload triggers this)

Expected Results:  
Data flow should stop when leaving the page.

The data flow will stop of course if the tab or window is closed.

Comment 1

[pd]

I have experienced this problem on Windows XP so I suggest this bug is not limited to just the Linux platform.

Comment 2

[Thomas B. Rücker [account mostly dormant]]

I've set it to generic, after all it's core and should be platform independent.

Comment 3

[pd]

Should the status change from unconfirmed to confirmed?

Comment 4

[Biju]

This issue is similar to bug 449096 
and was fixed on windows by fix for bug 451457.

But now another situation like bug 470636 is happening in windows 
whether that is happening on Linux also?

Key difference of bug 470636 is 
1. "In addition it won't play the same URI in any other page"
no bug 470636 will allow same uri on another tab

2. "even a reload triggers this"
no bug 470636 will stop playing

Comment 5

[cajbir (:cajbir)]

This download still occurs because the media is still in the bfcache, and is paused. When a media playback is paused it still continues to download from the net. On Freeze it should really suspend the download and resume it when Thawed in some way.

Comment 6

[cajbir (:cajbir)]

Attachment: First cut at a fix

This is a first cut at a fix. When the element is moved into the bfcache I call Suspend on the underlying channel, and Resume when it is brought back. This requires passing the suspend/resume calls from the element, to the decoder, to the reader, to the stream and from there to the channel.

Needs more testing, and applying to the wave backend as well.

Requires the patch in bug 470636 to be applied first, otherwise Freeze and Thaw never get called.

Comment 7

[cajbir (:cajbir)]

I think this should be blocking 1.9.1 as we don't want users using all their bandwidth when navigating pages and one of them happens to contain a large video or live stream.

Comment 8

[cajbir (:cajbir)]

Attachment: Fix wave backend

Add fix for wave backend.

Comment 9

[cajbir (:cajbir)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/7aec588d41a3

Comment 10

[cajbir (:cajbir)]

Pushed to mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5f04646ca782