460739 - Reduce output generated by StandardTests

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Marc]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: 

StandardTests generate a huge amount of output which gets written in the file TEST-org.mozilla.javascript.drivers.StandardTests.xml. This causes problems when the files needs to be processed (for instance when running the tests from CruiseControl).

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Marc]

Attachment: Patch reducing output of StandardTests

This patch allows to drastically reduce output volume of StandardTests (>90%, can't say the precise %, I don't have any original version of the result file anymore). As a side effect it seems to me that the execution time is significantly reduced as well.

Comment 2

[Attila Szegedi]

Attachment: improvement on the previous patch

Here's a bit different patch. The difference is that it won't affect the tests when run from the command line at all (using JsDriver), but will only reduce the output for JUnit-run tests.

Comment 3

[Marc]

I see that you're extremely prudent with these tests ;-) Perhaps a test to test how the tests should run would be interesting ;-)

These changes are ok for me as they should achieve the same result when running the junit tests from the build.

Comment 4

[Attila Szegedi]

Writing tests for tests that test how the tests should run is a path to madness caused by fear of Thompson hacks :-)

"I recompile my firmware regularly, thank you so much for your concern. Using a third-party compiler. One that I've bootstrapped myself, starting out on an alarm clock controller and working up from there."

Comment 5

[Marc]

Attachment: Patch reporting exception that occured in test thread

We've been wrong fighting again the consequence of the problem rather than against the cause.
The root of the problem here is that not all exceptions occurring in the test threads are captured and reported as they should. The consequence is that a large number of test failures have been ignored and tests marked as successful whereas they failed :-(
With this patch *all* exceptions and errors occurring in the test thread are captured and reported. The consequence is that instead of 150 failed tests with CVS head, I have now 815 failed tests!

Comment 6

[Attila Szegedi]

Reviewed and committed Marc's latest patch:

    Checking in testsrc/org/mozilla/javascript/drivers/StandardTests.java;
    /cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/drivers/StandardTests.java,v  <--  StandardTests.java
    new revision: 1.9; previous revision: 1.8
    done
    Checking in testsrc/org/mozilla/javascript/drivers/ShellTest.java;
    /cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/drivers/ShellTest.java,v  <--  ShellTest.java
    new revision: 1.10; previous revision: 1.9
    done

Comment 7

[Hannes Wallnoefer]

Since Attila committed Marc's patch I think the bug should be resolved fixed.