Closed Bug 460765 Opened 16 years ago Closed 16 years ago

Sisyphus - JavaScript Tests - bisect.sh directory munging bug

Categories

(Testing Graveyard :: Sisyphus, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The JavaScript tests use the TEST_DIR environment variable to compute the web path to the javascript tests by removing $TEST_DIR from the physical path, TEST_JSDIR, to the JavaScript test directory. 

On Windows, there is a conflict between the normal path (sans the drive prefix /c/) and the cygwin path including the drive prefix. 

The bisect.sh script uses set-build-env.sh to set the build environment variables which are used to locate the build trees being bisected. A side-effect of this call is to convert the TEST_DIR value to one including the drive prefix. Currently, the TEST_JSDIR is set in bisect.sh prior to the calling of set-build-env.sh. This causes the computation of the web path to the JavaScript tests to fail since TEST_JSDIR will not longer contain TEST_DIR as a prefix.

This patch moves the computation of TEST_JSDIR to after the call to set-build-env.sh so that TEST_DIR and TEST_JSDIR both use the drive prefix consistently when bisecting.
Flags: in-testsuite-
Flags: in-litmus-
/cvsroot/mozilla/js/tests/bisect.sh,v  <--  bisect.sh
new revision: 1.4; previous revision: 1.3

http://hg.mozilla.org/mozilla-central/rev/0335765d3786
Status: NEW → RESOLVED
Closed: 16 years ago
OS: All → Windows XP
Hardware: All → PC
Resolution: --- → FIXED
Summary: Sisyphus - JavaScript - bisect.sh directory munging bug → Sisyphus - JavaScript Tests - bisect.sh directory munging bug
Mass move of Sisyphus bugs to Testing : Sisyphus. Filter on SisyphusMassMove to ignore.
Component: Testing → Sisyphus
Flags: in-litmus-
Product: Core → Testing
QA Contact: testing → sisyphus
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: