460880 - keyword javascript bookmarklets that open new tabs are popup blocked when places database is over a certain size

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[al_9x]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080829 Firefox/2.0.0.17 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

The simplest form of such a bookmark is "javascript:void open('http://www.google.com/');"  They were being blocked as popups, which is abnormal.

I was able to get them to open by reducing the size of the places database by deleting bookmarks, it worked again at 2005 moz_bookmarks.  Once the threshold was found I could break it again and fix it by adding and removing a few bookmarks.

The initial places database was generated from a large FF2 bookmarks file.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Marco Bonardo [:mak]]

not enought steps/informations to reproduce, and i can't see how reducing size of a table could involve browser code that handles popups...

Comment 2

[al_9x]

(In reply to comment #1)
> not enought steps/informations to reproduce, and i can't see how reducing size
> of a table could involve browser code that handles popups...

Nevertheless this is happening, on two different machines.  I can break in Venkman in the onPopupBlocked event in chrome://global/content/bindings/browser.xml, after executing a multiple tab opening bookmarklet.  Let's forget for the moment about the size of the table and try to figure out why a bookmarklet javascript:open() is treated as a popup  

Where does the decision about a nav being a popup get made?  Perhaps I can debug there and give you more info.

Comment 3

[Shawn Wilsher :sdwilsh]

We don't have a component for pop-up blocking as far as I can tell, but this doesn't belong in Bookmarks & History (nor does it belong in Location Bar & Autocomplete)

Comment 4

[al_9x]

some more info,(In reply to comment #3)
> We don't have a component for pop-up blocking as far as I can tell, but this
> doesn't belong in Bookmarks & History (nor does it belong in Location Bar &
> Autocomplete)

I've confirmed this on 3.1b3, new profile, the size of the places.sqlite is 6.33MB, the actual keyworded bookmark url is: "javascript:open('http://www.google.com/search?q=%s');open('http://search.live.com/results.aspx?q=%s');open('http://search.yahoo.com/search?p=%s');open('http://www.altavista.com/web/results?q=%s');void%20open('http://www.ask.com/web?q=%s');"

This is a major regression, sqlite is supposed to allow for larger history and bookmarks but instead FF2 works fine and FF3.X misbehaves.

I am sure Mozilla QA has access to a large history.dat + bookmarks.html or places.sqlite, can some one try to repro this?

I would like to debug this on my end, even if it's not just javascript, I'll try  to build a debug version, I just need a hint as to what I should focus on, probably the code that decides that an open() needs to be blocked is significant, where is it?

Comment 5

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.13 or later in safe mode or a fresh profile? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 6

[al_9x]

fixed in 3.6