46090 - <dl><dd><ul> is red

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Mats Palmgren (inactive)]

REPEAT-BY:
1. load the following markup:

<dl>
    <dt></dt>
    <dd>
        <ul>
            <li>JSR 72  Generic Security Services API
        </ul>
    </dd>
</dl>

ACTUAL: the text is red
EXPECTED: the text should be black

I am using build 2000-07-20-08 on Windows 98 SE.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Henri Sivonen (:hsivonen) (temporarily away from Bugzilla)]

Confirmed in compat mode. Does not occur in standards mode in Mac build
2000071810. I'm inclined to believe this is an All/All issue.

Comment 3

[Mats Palmgren (inactive)]

Digging further - I found the following in quirk.css:

/* Quirk: UL under a DL has no margins  (b=32989) */
dl ul {
  margin: 0 0 0 0;
  color: red;
}

If I remove "color: red;", the problem goes away...

Comment 4

[Hixie (not reading bugmail)]

LOL!

According to CVS blame, that was code written by Marc. Reassigning.

Nominating for nsbeta2 -- this is a VERY EASY fix, extremely low risk.

Comment 5

[Marc Attinasi]

That's is defined in the spec! Oh, wait a minute, it is suppossed to be blue. 
Just kidding - ha ha.

PDT: we must remove the 'color: red' rule as it was a test rule that was not 
removed when the real fix was checked in (the margin part). There is no such 
thing as lower risk than this fix.

Comment 6

[Marc Attinasi]

Attachment: PATCH to fix this: removes the color rule

Comment 7

[Marc Attinasi]

Attachment: Ignore previous patch, wrong file: this is the patch, really.

Comment 8

[Pierre Saslawsky]

My trick on the Mac to avoid inadvertantly checking in some test code is to put 

big 'bullet' characters in comments.

Comment 9

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2.  Adding "nsbeta3" keyword 
for consideration of a fix for that milestone.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What?????????????

Comment 11

[Marc Attinasi]

I'm very tempted to check this in anyway and risk having my head severed...

Comment 12

[Hixie (not reading bugmail)]

Marc: Ok, r=ianh. Now to get approval from mozilla.org:

Brendan/Waterson: This is a very low risk patch which improves rendering on
moderately complex pages. Could we have approval to checkin please?

Comment 13

[Chris Waterson]

a=waterson

Comment 14

[Marc Attinasi]

Fix checked in (quirk.css) <Thanks Ian and Chris W.>

Comment 15

[Hixie (not reading bugmail)]

VERIFIED Win2K and Linux Comm M18 trunk builds 2000090609.