460909 - Mass edit bug form does not allow adding private comments

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[David Lawrence [:dkl]]

Attachment: Patch to add private comment in mass bug edit form (v1)

The mass edit form in buglist.cgi does not display the "Private" checkbox that is normally displayed in a single bug show_bug.cgi. 

Attaching patch that adds the private checkbox to edit-multiple.html.tmpl.

Dave

Comment 1

[Frédéric Buclin]

Comment on attachment 344018 [details] [diff] [review]
Patch to add private comment in mass bug edit form (v1)

>+[% IF Param("insidergroup") && user.in_group(Param("insidergroup")) %]

Please write [% IF user.is_insider %]. I know you copied this code from bug/edit/html.tmpl, but it's old code.


>+         onClick="updateCommentTagControl(this, form)"/>

updateCommentTagControl() is undefined in this template. Its definition is in bug/edit.html.tmpl. You probably have to move this function in one of the js/*.js files.

Also, note that this implementation annoys me due to bug 299895, i.e. allowing each product to have its own insider group. Maybe when bug 299895 is implemented, all we have to do is to add a warning here that the privacy bit will only apply to products where the user belongs to the insider group.

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to add private comment in mass bug edit form (v2)

Updated patch attached:

1. Use user.is_insider instead of user.in_group()
2. Moved getCommentTagControl to js/field.js which is already imported by 
   show_bug.cgi and buglist.cgi.

I also agree that having an insider group(s) per product would be very useful as I have had that requested here as well. I would be able to test such a patch something was implemented in the future.

Dave

Comment 3

[Frédéric Buclin]

Comment on attachment 344121 [details] [diff] [review]
Patch to add private comment in mass bug edit form (v2)

>Index: template/en/default/list/edit-multiple.html.tmpl

>+[% IF Param("insidergroup") && user.is_insider %]

No, Param("insidergroup") must go away. Simply write [% IF user.is_insider %].

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to add private comment in mass bug edit form (v3)

Missed that user.is_insider also checks for Bugzilla->params->{insidergroup} pointed out by LpSolit.

New patch for review.

Dave

Comment 5

[Frédéric Buclin]

Comment on attachment 344230 [details] [diff] [review]
Patch to add private comment in mass bug edit form (v3)

Works fine. r=LpSolit

Note that you have to fix the bitrot in js/field.js as new functions have been added there meanwhile. As I had to unbitrot it myself to test your patch, I will attach the unbitrotten patch, so that you just have to apply it, cleanly.

Comment 6

[Frédéric Buclin]

Attachment: unbitrotten patch, v3.1

Comment 7

[David Lawrence [:dkl]]

tip:
Checking in js/field.js;
/cvsroot/mozilla/webtools/bugzilla/js/field.js,v  <--  field.js
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.143; previous revision: 1.142
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.52; previous revision: 1.51
done

Comment 8

[Max Kanat-Alexander]

Added to the release notes for Bugzilla 3.4 in bug 494037.