Build problem when using --with-branding-dir

RESOLVED INVALID

Status

()

Product:
Firefox
Component:
General
RESOLVED INVALID
Reported:
9 years ago
Modified:
9 years ago

People

(Reporter: reed, Assigned: Alexander Sack)

Tracking

Version:
Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

•
9 years ago 
Created attachment 344022 [details] [diff] [review]
patch - v1

Apparently, there's a build problem when using --with-branding-dir and the unofficial branding directory. Patch attached to fix that.

Taken from Ubuntu bzr repo.
Attachment #344022 - Flags: review?(gavin.sharp)
 (Reporter)

Updated

•
9 years ago
Assignee: fta+bugzilla → asac

Comment 1

•
9 years ago 
Why isn't top_srcdir correct?

Comment 2

•
9 years ago 
To be clear, I mean: why isn't @top_srcdir@ set to the correct value?

Comment 3

•
9 years ago 
I just checked the history of that patch in the ubuntu branches, it has been introduced long ago.

Now, when building browser from trunk with --with-branding=browser/branding/unofficial and --with-libxul-sdk, i get:

DEPTH = ../../..
topsrcdir = ../../..

so it's no longer needed. I will drop this patch from our tree.
 (Reporter)

Updated

•
9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
 (Reporter)

Updated

•
9 years ago
Attachment #344022 - Attachment is obsolete: true
Attachment #344022 - Flags: review?(gavin.sharp)
You need to log in before you can comment on or make changes to this bug.