Created attachment 344022 [details] [diff] [review] patch - v1 Apparently, there's a build problem when using --with-branding-dir and the unofficial branding directory. Patch attached to fix that. Taken from Ubuntu bzr repo.
Why isn't top_srcdir correct?
To be clear, I mean: why isn't @top_srcdir@ set to the correct value?
I just checked the history of that patch in the ubuntu branches, it has been introduced long ago. Now, when building browser from trunk with --with-branding=browser/branding/unofficial and --with-libxul-sdk, i get: DEPTH = ../../.. topsrcdir = ../../.. so it's no longer needed. I will drop this patch from our tree.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.