Closed Bug 460915 Opened 16 years ago Closed 16 years ago

Build problem when using --with-branding-dir

Categories

(Firefox :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: reed, Assigned: asac)

Details

Attachments

(1 obsolete file)

Attached patch patch - v1 (obsolete) — Splinter Review
Apparently, there's a build problem when using --with-branding-dir and the unofficial branding directory. Patch attached to fix that.

Taken from Ubuntu bzr repo.
Attachment #344022 - Flags: review?(gavin.sharp)
Assignee: fta+bugzilla → asac
Why isn't top_srcdir correct?
To be clear, I mean: why isn't @top_srcdir@ set to the correct value?
I just checked the history of that patch in the ubuntu branches, it has been introduced long ago.

Now, when building browser from trunk with --with-branding=browser/branding/unofficial and --with-libxul-sdk, i get:

DEPTH = ../../..
topsrcdir = ../../..

so it's no longer needed. I will drop this patch from our tree.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Attachment #344022 - Attachment is obsolete: true
Attachment #344022 - Flags: review?(gavin.sharp)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: