460971 - Hide shortcut (Cmd-H) doesn't work

Status: VERIFIED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Alfredo Sola]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; es; rv:1.8.1.17) Gecko/20080915 Camino/1.6.4 (MultiLang) (like Firefox/2.0.0.17)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; es-ES; rv:1.9.1b1pre) Gecko/20081006 Shredder/3.0a3

The Cmd-H shortcut to hide an application works basically everywhere, but it does not on Thunderbird 3 a3 (Spanish localization, just in case it is relevant)


Reproducible: Always

Comment 1

[Phil Ringnalda (:philor)]

Worksforme in en-US, though I don't know whether that means it's specific to es-ES or to your machine.

Comment 2

[Stefan [:stefanh]]

es-ES/mail/chrome/messenger/messenger.dtd:

<!ENTITY hideThisAppCmdMac.commandkey "O">
<!ENTITY hideThisAppCmdMac.modifiers "accel">
<!ENTITY hideOtherAppsCmdMac.label "Ocultar otros">
<!ENTITY hideOtherAppsCmdMac.commandkey "O">

I guess "O" works...

So, I think "H" is the right key - even for es-ES. Note that this is a very standardized mac shortcut for hiding the app and I doubt that, for instance, the es version of Safari/Mail/etc etc has anything else that cmd+H (and cmd+opt+H for hiding all other apps) here... Note also that browser/ has "H". Axel might want to take a look at this: http://mxr.mozilla.org/l10n-central/search?string=hideThisAppCmdMac.commandkey

Comment 3

[RickieES aka Ricardo Palomares]

(In reply to comment #2)
> es-ES/mail/chrome/messenger/messenger.dtd:
> 
> <!ENTITY hideThisAppCmdMac.commandkey "O">
> <!ENTITY hideThisAppCmdMac.modifiers "accel">
> <!ENTITY hideOtherAppsCmdMac.label "Ocultar otros">
> <!ENTITY hideOtherAppsCmdMac.commandkey "O">
> 


Sorry, I don't usually touch commandkeys, but I mistakenly got these as accesskeys and translated them. They are fixed now in my MozillaTranslator glossary, and I will probably push them along with the most recent changes in Thunderbird tomorrow.

Comment 4

[Stefan [:stefanh]]

I filed a bug for es-AR (and all the others as well)

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to comment #3)
> Sorry, I don't usually touch commandkeys, but I mistakenly got these as
> accesskeys and translated them. They are fixed now in my MozillaTranslator
> glossary, and I will probably push them along with the most recent changes in
> Thunderbird tomorrow.


Although with a huge bunch of other removed entities, the changes have been pushed to the repository:

http://hg.mozilla.org/l10n-central/es-ES/diff/6b6f3f2cd3af/mail/chrome/messenger/messenger.dtd


And, thanks to recent enhancements in build machines configuration, there is already an es-ES langpack to test it in latest TB en-US binary:

ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk-l10n/thunderbird-3.0b1pre.es-ES.langpack.xpi

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #5)
> Although with a huge bunch of other removed entities, the changes have been
> pushed to the repository:
> 
> http://hg.mozilla.org/l10n-central/es-ES/diff/6b6f3f2cd3af/mail/chrome/messenger/messenger.dtd
> 
> 
> And, thanks to recent enhancements in build machines configuration, there is
> already an es-ES langpack to test it in latest TB en-US binary:
> 
> ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk-l10n/thunderbird-3.0b1pre.es-ES.langpack.xpi



I don't have access to a Mac machine, so I can't really test it. Anyone could download a Mac OS X binary and test it?

ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk-l10n/

The binary status largely depends of es-ES status matching en-US, but right now we are synched and binaries should work as well (or bad) ;-) as en-US ones.

Comment 7

[Alfredo Sola]

> I don't have access to a Mac machine, so I can't really test it. Anyone could
> download a Mac OS X binary and test it?

Downloaded, hit Cmd-H. Now works as expected.

Comment 8

[RickieES aka Ricardo Palomares]

Marking VERIFIED as per comment #7.