Log POP errors to the PR_LOG module

RESOLVED FIXED in mozilla1.9.1b2

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla1.9.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 344168 [details] [diff] [review]
The fix

At the moment we have an Error() function in nsPop3Protocol that will display errors to the user.

However, this function has no console-based form of logging; this means we don't see what errors the user has been presented with (if using NSPR_LOG_MODULES) and we have no chance of seeing what is going on in xpcshell tests.

The attached patch adds a PR_LOG line so that we'll log the error. It still means for xpcshell tests that NSPR_LOG_MODULES needs enabling for pop, but its certainly better than the situation now.
Attachment #344168 - Flags: superreview?(bienvenu)
Attachment #344168 - Flags: review?(bienvenu)

Updated

10 years ago
Attachment #344168 - Flags: superreview?(bienvenu)
Attachment #344168 - Flags: superreview+
Attachment #344168 - Flags: review?(bienvenu)
Attachment #344168 - Flags: review+
(Assignee)

Comment 1

10 years ago
Checked in, changeset id: http://hg.mozilla.org/comm-central/rev/af9bdd73afd8
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.