Closed
Bug 461051
Opened 16 years ago
Closed 16 years ago
Thunderbird and Sunbird build failure with --enable-official_branding
Categories
(MailNews Core :: Build Config, defect, P1)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: mnyromyr, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(2 files)
833 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
838 bytes,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
TB debug trunk fails when compiling with --enable-official_branding: make[5]: Leaving directory `/home/kd/projekte/mozilla/mozilla.org/obj/tb/other-licenses/branding/thunderbird/locales' /home/kd/moz/obj/tb/config/nsinstall -D ../../../mozilla/dist/branding make[4]: /home/kd/moz/obj/tb/config/nsinstall: Command not found make[4]: *** [export] Error 127 make[4]: Leaving directory `/home/kd/projekte/mozilla/mozilla.org/obj/tb/other-licenses/branding/thunderbird' make[3]: *** [export_tier_app] Error 2 make[3]: Leaving directory `/home/kd/projekte/mozilla/mozilla.org/obj/tb' make[2]: *** [tier_app] Error 2 make[2]: Leaving directory `/home/kd/projekte/mozilla/mozilla.org/obj/tb' make[1]: *** [default] Error 2 make[1]: Leaving directory `/home/kd/projekte/mozilla/mozilla.org/obj/tb' make: *** [build] Error 2 It *does* build without --enable-official_branding. SM does build as well (it doesn't take --enable-official_branding anyway).
I can confirm this also for Mac OS X (but its not a debug build). /temp/src/obj-i386-apple-darwin9.5.0/mozilla/config/nsinstall -L /temp/src/obj-i386-apple-darwin9.5.0/directory/xpcom/base/public -m 644 _xpidlgen/nsILDAPConnection.h _xpidlgen/nsILDAPOperation.h _xpidlgen/nsILDAPMessage.h _xpidlgen/nsILDAPMessageListener.h _xpidlgen/nsILDAPURL.h _xpidlgen/nsILDAPErrors.h _xpidlgen/nsILDAPServer.h _xpidlgen/nsILDAPService.h _xpidlgen/nsILDAPBERValue.h _xpidlgen/nsILDAPControl.h _xpidlgen/nsILDAPBERElement.h _xpidlgen/nsILDAPModification.h ../../../../mozilla/dist/include/mozldap Creating .deps /temp/src/obj-i386-apple-darwin9.5.0/config/nsinstall -D ../../../mozilla/dist/branding make[4]: /temp/src/obj-i386-apple-darwin9.5.0/config/nsinstall: Command not found make[4]: *** [export] Error 127 make[3]: *** [export_tier_app] Error 2 make[2]: *** [tier_app] Error 2 make[1]: *** [default] Error 2 make: *** [build] Error 2
Comment 2•16 years ago
|
||
I see a similar bustage but a different error on win32 too: make[4]: Entering directory `/e/obj/tb/other-licenses/branding/thunderbird' make[5]: Entering directory `/e/obj/tb/other-licenses/branding/thunderbird/locales' cat: /e/dev/comm-central/src/mozilla/mail/config/version.txt: No such file or directory Traceback (most recent call last): File "e:/dev/comm-central/src/mozilla/config/JarMaker.py", line 463, in <module> main() File "e:/dev/comm-central/src/mozilla/config/JarMaker.py", line 451, in main assert srcdir.startswith(topsrc), "src dir %s not in topsrcdir %s" % (srcdir, topsrc) AssertionError: src dir e:\dev\comm-central\src\other-licenses\branding\thunderbird\locales not in topsrcdir e:\dev\comm-central\s rc\mozilla make[5]: *** [libs] Error 1 make[5]: Leaving directory `/e/obj/tb/other-licenses/branding/thunderbird/locales'
This is because of http://hg.mozilla.org/mozilla-central/rev/dabc1188242e I get rid of this bug if I remove this lines.
Assignee | ||
Comment 4•16 years ago
|
||
(In reply to comment #3) > This is because of > http://hg.mozilla.org/mozilla-central/rev/dabc1188242e > I get rid of this bug if I remove this lines. I'm not sure I quite see why those have broken it. I'm starting to think we need a way to disable the core branding directory stuff completely - I'll try and take a look over the weekend.
Assignee | ||
Comment 5•16 years ago
|
||
I have been doing some digging. It appears that the problem lines are those mentioned in comment 3. There are probably two problems here. The first problem is that with those lines in allmakefiles.sh the mozilla-central build system is constructing the branding Makefiles files even though they are really browser specific. The second problem is that comm-central isn't generating those makefiles. This patch moves the generation of the branding makefiles from allmakefiles.sh to browser/makefiles.sh - this means that only when browser is built from mozilla-central do we attempt to build those files - when xulrunner is built, we shouldn't be building those makefiles. I'll attach a patch in a moment for the comm-central changes to fix the build system there so that it correctly generates and tidies those makefiles.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #344650 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 6•16 years ago
|
||
Attachment #344651 -
Flags: review?(kairo)
Assignee | ||
Updated•16 years ago
|
Version: unspecified → Trunk
Assignee | ||
Updated•16 years ago
|
Assignee: bugzilla → nobody
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
Comment 8•16 years ago
|
||
Comment on attachment 344651 [details] [diff] [review] [checked in] comm-central fix the patch looks good to me, I take for granted that you tested it with all your variants of branding. a=me by code inspection.
Attachment #344651 -
Flags: review?(kairo) → review+
I've applied this two patches on my own thunderbird build (Mac OS X) and was able to build TB with and without official branding without any problems. :)
Comment 10•16 years ago
|
||
"Clobber" would be more accurate than "debug" - even though I must have seen comment 1, I still spent several hours this afternoon trying to recover from having removed my objdir for my static/opt build, before I finally remembered, applied these two patches for one build, and was then able to get on with life. And even though without bug 462811 fixed we can't mark it so, this blocks 3.0b1 if we're going to do the Firefox thing and do betas with official branding.
Assignee: nobody → bugzilla
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Summary: trunk debug build failure with --enable-official_branding → Thunderbird build failure with --enable-official_branding
Updated•16 years ago
|
Flags: blocking-thunderbird3+
Target Milestone: --- → Thunderbird 3.0b1
Updated•16 years ago
|
Summary: Thunderbird build failure with --enable-official_branding → Thunderbird and Sunbird build failure with --enable-official_branding
Assignee | ||
Comment 11•16 years ago
|
||
Comment on attachment 344651 [details] [diff] [review] [checked in] comm-central fix Checked in: http://hg.mozilla.org/comm-central/rev/ab3599299723 I have pushed the comm-central part of this bug, from my tests it should fix the official branding problem. I still think the mozilla-central fix should go in, or some other improvement done for the branding interaction between mozilla-central and comm-central. I don't know what that fix is yet if there is one. If someone can confirm for me that just the comm-central part is good enough to get this going again, then we'll drop this off the blocking list.
Attachment #344651 -
Attachment description: comm-central fix → [checked in] comm-central fix
Updated•16 years ago
|
Attachment #344650 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•16 years ago
|
Whiteboard: [should be fixed, needs verification, then can come of blocking][waiting for m-c to reopen]
Comment 12•16 years ago
|
||
Current belief is that this is fixed well enough to not block Thunderbird 3. Setting the blocking-thunderbird3-. Feel free to renominate if that's not the case.
Flags: blocking-thunderbird3+ → blocking-thunderbird3-
Assignee | ||
Comment 13•16 years ago
|
||
Comment on attachment 344650 [details] [diff] [review] [checked in] mozilla-central fix Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/rev/def8ca28ac75
Attachment #344650 -
Attachment description: mozilla-central fix → [checked in] mozilla-central fix
Assignee | ||
Comment 14•16 years ago
|
||
Both patches now checked in, I'm not too worried about getting the FF patch on 1.9.1 at this stage as we seem to be working reasonably fine without it (unless anything changes at which stage I'll request approvals).
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [should be fixed, needs verification, then can come of blocking][waiting for m-c to reopen]
You need to log in
before you can comment on or make changes to this bug.
Description
•