Closed
Bug 461075
Opened 16 years ago
Closed 16 years ago
Replace deprecated nsAutoString with nsString
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)
Details
Attachments
(1 file)
103.57 KB,
patch
|
stuart.morgan+bugzilla
:
review-
|
Details | Diff | Splinter Review |
We use nsAutoString all over the place. Apparently -- though MDC certainly makes this difficult to figure out -- it's deprecated, so we should move away from it. Patch coming shortly, as soon as I can pull a clean tree and F&R.
Assignee | ||
Comment 1•16 years ago
|
||
This oughta do it.
Attachment #344220 -
Flags: review?(stuart.morgan+bugzilla)
Comment 2•16 years ago
|
||
Wait, now I'm confused. kreeger, the header you linked to in the other bug was nsStringAPI, which we don't use; we use internal string linkage. As far as I can tell from a brief look around: - nsAutoString is still alive and well for internal usage, and - nsAutoString is still preferred for stack-based usage. This isn't just a typedef for us, this has completely different memory semantics that aren't desirable. Is there something I'm missing?
Updated•16 years ago
|
Attachment #344220 -
Flags: review?(stuart.morgan+bugzilla) → review-
Comment 3•16 years ago
|
||
Comment on attachment 344220 [details] [diff] [review] fix v1.0 I talked to kreeger on IRC; he thought we were on frozen string linkage, but I'm 99% sure we are not, which means this change has real performance implications that I don't think we want. Given our current understanding I'd say this bug is a WONTFIX (and if you want to change the nsString usage in that other patch, feel free)
(In reply to comment #3) > (From update of attachment 344220 [details] [diff] [review]) > I talked to kreeger on IRC; he thought we were on frozen string linkage, but > I'm 99% sure we are not, which means this change has real performance > implications that I don't think we want. Bug 407457 still has open deps, for starters.
WONTFIXing this per comment 3.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•