Closed Bug 461085 Opened 16 years ago Closed 16 years ago

RFE: export function CERT_CompareCerts

Categories

(NSS :: Libraries, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
3.12.3

People

(Reporter: rocketraman, Assigned: nelson)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3
Build Identifier: 

As per bug #354273, function CERT_CompareCerts needs to be exported.

Reproducible: Always
Blocks: 354273
Assignee: nobody → nobody
Component: General → Libraries
Product: Thunderbird → NSS
QA Contact: general → libraries
thanks, Phil.
Assignee: nobody → nelson
OS: Linux → All
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → 3.12.3
Version: unspecified → trunk
This should do it.
Attachment #344448 - Flags: review?(kaie)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 344448 [details] [diff] [review]
patch v1 - export symbol

That's one rather trivial function.

Also its implementation can be optimized by checking that pointers are equal, since typically most certs that have the same DER will end up pointing back to the same structure.
Attachment #344448 - Flags: review?(kaie) → review+
Yes, I think that optimization actually belongs in SECITEM_CompareItem.
I'm surprised it isn't already there.
Attachment #344943 - Flags: review?(julien.pierre.boogz)
Attachment #344943 - Flags: review?(julien.pierre.boogz) → review+
Checking in nss/nss.def;    new revision: 1.195; previous revision: 1.194
Checking in util/secitem.c; new revision: 1.15; previous revision: 1.14
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.