User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:22.214.171.124) Gecko/2008092416 Firefox/3.0.3 Build Identifier: As per bug #354273, function CERT_CompareCerts needs to be exported. Reproducible: Always
Created attachment 344448 [details] [diff] [review] patch v1 - export symbol This should do it.
Comment on attachment 344448 [details] [diff] [review] patch v1 - export symbol That's one rather trivial function. Also its implementation can be optimized by checking that pointers are equal, since typically most certs that have the same DER will end up pointing back to the same structure.
Yes, I think that optimization actually belongs in SECITEM_CompareItem. I'm surprised it isn't already there.
Created attachment 344943 [details] [diff] [review] patch part 2, v1 - optimization
Checking in nss/nss.def; new revision: 1.195; previous revision: 1.194 Checking in util/secitem.c; new revision: 1.15; previous revision: 1.14