461086 - conversion from RawPtrType to already_AddRefed<RawPtrType> should be explicit

Status: RESOLVED DUPLICATE of bug 345225

(Core :: XPCOM, defect)

Description

[Karl Tomlinson (:karlt)]

Automatically converting from a type that hasn't been AddRefed to one that
says it has been AddRefed seems wrong.

Unfortunately there seem to be a large number of

  already_AddRefed<T>
  getT()
  {
      T *ret = new T();
      NS_IF_ADDREF(ret);
      return ret;
  }

Something like the following would be nice:

  already_AddRefed<T>
  getT()
  {
      T *ret = new T();
      return do_AddRef(ret);
  }