461096 - Small buttons in Mac account manager break number textbox spinbuttons

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P3)

Description

[DP]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: 3.0a3

Under Manage Accounts.  If you hit the down arrow to lower the number of minutes under "Check for New Messages Every x minute", the number only goes up not down.

Reproducible: Always

Steps to Reproduce:
1.Goto Tools, then Account Settings
2.Goto Server setting for any of the accounts
3.Click on the down arrow to lower number of minutes before checking for new mail
Actual Results:  
The number goes up not down.

Expected Results:  
The number should decrease.

Comment 1

[Mark Banner (:standard8)]

I've just tried this on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081020 Lightning/1.0pre Shredder/3.0b1pre.

Initially I couldn't reproduce, then I noticed, if you click on anywhere around the top half of the down arrow, the number goes up, if you click on the bottom half of the down arrow, the number goes down.

Comment 2

[Phil Ringnalda (:philor)]

Weird. I see that in Tbird's account manager, but not Tbird's prefs or SeaMonkey's account manager, so it must be some bogus Tbird css.

Comment 3

[Mark Banner (:standard8)]

True, I don't see it in prefs either.

Comment 4

[Mark Banner (:standard8)]

We do have some interesting css (according to domi):

http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/accountManage.css#72

page button {
  min-height: 19px; /* aqua size for small buttons */
}

I'm not quite sure how to fix this without breaking the size of the rest of the buttons.

Comment 5

[DP]

Maybe the solution here is to do away with the button.  Not sure if it's even necessary.  A typical user doesn't change it once set.  It's faster just typing in a number.

Comment 6

[Phil Ringnalda (:philor)]

Oh, I don't think that'll be necessary - I'd forgotten that I already fixed a similar problem with spinbuttons in the prefwindow, by way of bug 377114. While we could keep using the equivalent of native small buttons (and get rid of that most-expensive-possible selector) with some more cunning selectors to keep the dialog buttons large, the spinbuttons the size they want to be, and only button-buttons small, I think the more direct approach of just using normal sized buttons is probably what we want to do.

Comment 7

[Phil Ringnalda (:philor)]

Attachment: First better idea

I changed my mind about dumping small buttons, for two reasons:

* we're right up against the limit of the dialog size for POP server settings, and close for IMAP; using normal size buttons would mean that either something needs to go elsewhere, or we'd have to squish everything together a bit, or increase the whole dialog's size.

* small buttons actually do look better - I was staring at the server settings pane, wondering what could leave, when I realized that with big buttons, the [Advanced] button jumps out of the page, overshadowing the rest, and in almost every case, buttons in the AM aren't the thing that should be most visible.

The selector is still evil, and what you're never supposed to use, but we're talking about very few buttons, and a very shallow DOM to have to traverse up to the top for each, looking for a page parent. Doesn't strike me as worth rewriting the whole thing over.

Comment 8

[DP]

I still vote for getting rid of the spinner box all together to set the increment.  :-)

Comment 9

[Phil Ringnalda (:philor)]

That's not the only numberbox with spinbuttons in the account manager, and "remove them all for all OSes in all products because they overlap in Tb/Mac" is a lousy reason. If you think they should all be removed, or you think that particular ones should be removed, for some other reason, please file a separate bug with detailed reasoning about why someone with a mouse in their hand wouldn't want to increase the time by a few minutes by clicking, and would instead prefer to switch to the keyboard (but be prepared for us to ask you what on earth you were doing using them, to find this bug, if they're useless).

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 346217 [details] [diff] [review]
First better idea

On second thought, I don't want to own blame on a descendant selector.

Comment 11

[Phil Ringnalda (:philor)]

Attachment: Second better idea

:not() is the new black.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 346841 [details] [diff] [review]
Second better idea

Looks good.

Comment 13

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/154d2bc85592