Closed Bug 461121 Opened 14 years ago Closed 14 years ago

Thunderbird3: Move Invitations link into status bar

Categories

(Calendar :: Calendar Frontend, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Andreas suggested (and I agree), that we could move the invitations link into the statusbar, next to the unread count and total count. It would remain a link, or at least look clickable:


┆                                                                              ┆
β”œβ”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€
β”‚ β˜‰ β”‚ [Downloading Messages...   β–Ύ] β”‚ Invitations: 1 β”‚ Unread: 20 β”‚ Total: 791 β”‚
β””β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
Flags: tb-integration?
Thanks to browser wrapping, it of course doesn't look quite how I expected, but you get the picture ;-)

┆                                                                           ┆
β”œβ”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€
β”‚ β˜‰ β”‚ [Downloading Messages.. β–Ύ] β”‚ Invitations: 1 β”‚ Unread: 20 β”‚ Total: 791 β”‚
β””β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
I like it. Just to add:
- IMO if there are no open invitations, it should vanish.
- This bug may obsolete bug 460404.
Not sure if we should make it vanish. If we do, I think the thunderbird unread count should also vanish if there are no unread messages. Bryan, what do you think?

Novice users may wonder where their invitations went.
(In reply to comment #3)
> Novice users may wonder where their invitations went.

Does that mean you think answered invitations should appear in the dialog?
Priority: -- → P1
(In reply to comment #4)
> Does that mean you think answered invitations should appear in the dialog?

No, I would just advise to keep "Invitations: 0" in the statusbar in case we should also keep the unread count.
I suggest that the "Invitations: X" entry is shown only if there exists at least one switched on calendar that supports this feature. If e.g. only local calendars are used the entry useless and should not be displayed at all.
I just talked with christian:

* No calendars that support it, no invitations
* We should only show invitations if there are any.
Whiteboard: [needs patch]
Attached patch Fix - v1 β€” β€” Splinter Review
This patch takes care of the calendar side, its up to the thunderbird crew to decide to hide the unread count if its 0. This also fixes bug 404468, while we are at it.

This patch has ui=christian, as discussed.
Attachment #344280 - Flags: ui-review+
Attachment #344280 - Flags: review?(daniel.boelzle)
Whiteboard: [needs patch]
Sorry, missed a qrefresh. In calendar-common-sets.xul I also remove <command id="calendar_toggle_invitations_command"
Comment on attachment 344280 [details] [diff] [review]
Fix - v1

works as expected; r=dbo
Attachment #344280 - Flags: review?(daniel.boelzle) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/cccbb31e47b6>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Checked in lightning build 20081023044323 -> VERIFIED
Status: RESOLVED → VERIFIED
Flags: tb-integration?
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.