461121 - Thunderbird3: Move Invitations link into status bar

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect, P1)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Andreas suggested (and I agree), that we could move the invitations link into the statusbar, next to the unread count and total count. It would remain a link, or at least look clickable:


┆                                                                              ┆
├───┬───────────────────────────────┬────────────────┬────────────┬────────────┤
│ ☉ │ [Downloading Messages...   ▾] │ Invitations: 1 │ Unread: 20 │ Total: 791 │
└───┴───────────────────────────────┴────────────────┴────────────┴────────────┘

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Thanks to browser wrapping, it of course doesn't look quite how I expected, but you get the picture ;-)

┆                                                                           ┆
├───┬────────────────────────────┬────────────────┬────────────┬────────────┤
│ ☉ │ [Downloading Messages.. ▾] │ Invitations: 1 │ Unread: 20 │ Total: 791 │
└───┴────────────────────────────┴────────────────┴────────────┴────────────┘

Comment 2

[Daniel Boelzle [:dbo]]

I like it. Just to add:
- IMO if there are no open invitations, it should vanish.
- This bug may obsolete bug 460404.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Not sure if we should make it vanish. If we do, I think the thunderbird unread count should also vanish if there are no unread messages. Bryan, what do you think?

Novice users may wonder where their invitations went.

Comment 4

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> Novice users may wonder where their invitations went.

Does that mean you think answered invitations should appear in the dialog?

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #4)
> Does that mean you think answered invitations should appear in the dialog?

No, I would just advise to keep "Invitations: 0" in the statusbar in case we should also keep the unread count.

Comment 6

[Stefan Sitter [:ssitter]]

I suggest that the "Invitations: X" entry is shown only if there exists at least one switched on calendar that supports this feature. If e.g. only local calendars are used the entry useless and should not be displayed at all.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

I just talked with christian:

* No calendars that support it, no invitations
* We should only show invitations if there are any.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This patch takes care of the calendar side, its up to the thunderbird crew to decide to hide the unread count if its 0. This also fixes bug 404468, while we are at it.

This patch has ui=christian, as discussed.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Sorry, missed a qrefresh. In calendar-common-sets.xul I also remove <command id="calendar_toggle_invitations_command"

Comment 10

[Daniel Boelzle [:dbo]]

Comment on attachment 344280 [details] [diff] [review]
Fix - v1

works as expected; r=dbo

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/cccbb31e47b6>

-> FIXED

Comment 12

[Andreas Treumann]

Checked in lightning build 20081023044323 -> VERIFIED

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".