461138 - Setter for a Scriptable on host object doesn't accept null value

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Marc]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: 

When defining a setter on an host object for a field that implements Scriptable, Rhino throws EcmaError
org.mozilla.javascript.EcmaError: TypeError: Cannot convert null to an object.
when trying to assign null value.

A workaround consists in changing the signature of the setter to accept java.lang.Object instead of the desired Scriptable, but it is not pleasant.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Marc]

Attachment: Patch with unit test and fix

Comment 3

[Hannes Wallnoefer]

Attachment: revised patch

Just use ScriptRuntime.toObjectOrNull(). The only drawback is a potential extra call to ScriptRuntime.getTopCallScope() because toObjectOrNull doesn't take a scope argument, but I think that's acceptable for the simplified code.

Comment 4

[Hannes Wallnoefer]

Checking in src/org/mozilla/javascript/FunctionObject.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/FunctionObject.java,v  <--  FunctionObject.java
new revision: 1.82; previous revision: 1.81
done
RCS file: /cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/tests/CustomSetterAcceptNullScriptableTest.java,v
done
Checking in testsrc/org/mozilla/javascript/tests/CustomSetterAcceptNullScriptableTest.java;
/cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/tests/CustomSetterAcceptNullScriptableTest.java,v  <--  CustomSetterAcceptNullScriptableTest.java
initial revision: 1.1
done

Comment 5

[Marc]

I don't know if it matters here but getTopCallScope(Context) is evil when many scopes are involved, I wouldn't use it at all when an other solution is possible. Here we have a scope available, this information shouldn't be lost.