461166 - e4x parser borks on surrounding white spaces and certain response elements

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Reproducable with SOGo, if the xml response contains trailing \r\n's, then the parser says syntax error. Also I've noticed that when going through a <multistatus><D:response>...</..></..> construct, using multistatus.*.length() is not 1 but 3, multistatus.*[0] and [2] being "\n", multistatus.*[1] being the actual <D:response>.

This patch should take care. I'm not 100% sure that the <D:response> element is always in the DAV namespace, so my iteration of |multistatus.D::response| instead of the old |multistatus.*....| may not work out. Please test/comment on this for review.

Comment 1

[Andrew McMillan]

See section 11.2 of draft-desruisseaux-caldav-sched-05 - the response element should be in the CalDAV namespace.  This is not a change since -04 either - it was the same there.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

This patch is the same as the first, but uses *::response instead to take response elements from all namespaces into account.

Comment 3

[Daniel Boelzle [:dbo]]

Comment on attachment 345256 [details] [diff] [review]
Fix - v2

r=dbo

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/67040cc96e52>

-> FIXED

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".