Closed Bug 461170 Opened 16 years ago Closed 15 years ago

TM: js1_5/Exceptions/regress-333728.js fail

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta5-fixed

People

(Reporter: bc, Assigned: mrbkap)

References

Details

(Keywords: regression, testcase, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

tracemonkey branch, jit or not:

js1_5/Exceptions/regress-333728.js:

Throw ReferenceErrors for typeof(...undef): typeof (!this ? 0 : undef) reason: Expected value 'ReferenceError', Actual value 'undefined'

http://hg.mozilla.org/tracemonkey/rev/0a2f70e39663

Blake Kaplan <mrbkap@gmail.com> date: Fri Oct 17 18:59:05 2008 -0700 summary: Bug 460452 - NaN is a boolish false. Also constant fold booleans next to operator NOT. r=brendan
Flags: in-testsuite+
Flags: in-litmus-
Flags: blocking1.9.2?
Is this bug only on tm, not on 1.9.1 or m-c?

/be
this bug is on all branches: 1.9.1, 1.9.1 tracemonkey and 1.9.2
Flags: wanted1.9.2+
Flags: blocking1.9.2?
Flags: blocking1.9.2-
Flags: wanted1.9.2-
Flags: wanted1.9.2+
Flags: blocking1.9.2-
Flags: blocking1.9.2+
Priority: -- → P2
Assigning to blake.
Assignee: general → mrbkap
Attached patch Proposed fixSplinter Review
Note: I'm going to be out for a week, so any comments will have to be addressed by someone else if we want this to make the upcoming beta refresh.
Attachment #410807 - Flags: review?(brendan)
Comment on attachment 410807 [details] [diff] [review]
Proposed fix

>+        /*
>+         * Kluge to deal with typeof expressions: because constant folding

Kludge is the canonical spelling.

>+         * can turn an expression into a name node, we have to check here,
>+         * before folding, to see if we should throw undefined name errors.
>+         *
>+         * NB: We know that if pn->pn_op is JSOP_TYPEOF, pn1 will not be
>+         * null.  This assumption does not hold true for other unary

French spacing alert! Ok, I know you are there, but I'm not :-P.

r=me with nits picked.

/be
Attachment #410807 - Flags: review?(brendan) → review+
mrbkap, when you fix a test that has been previously marked as failing, you need to remove the fails from the test manifest. Otherwise it will show up as orange with unexpected passes.
Yikes, sorry about that. Fixed now: http://hg.mozilla.org/tracemonkey/rev/db862bf97839
http://hg.mozilla.org/mozilla-central/rev/e1ecbecb2f0e
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: