Closed Bug 461190 Opened 12 years ago Closed 11 years ago

Update Production 1.9 Unittests to run a11y tests suite

Categories

(Release Engineering :: General, defect, P2)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lsblakk, Assigned: lsblakk)

References

Details

Attachments

(2 files, 1 obsolete file)

Currently there are many discrepancies between the repo version and the currently-used version of the master.cfg and mozbuild.py

I would like to be able to use cvs repo version of master.cfg and mozbuild.py and so am attaching patches that do the needed clean up.

The mozbuild.py patch removes stale environment settings, replaces .pl with .py on some commands and also adds the a11y test commands

The master.cfg names the new (current) slaves, cleans out a couple of factories that are no longer needed (leopard, a duplicated osx, vista, xp) and also adds the call to a11y test for linux and mac.
Attachment #344312 - Flags: review?(bhearsum)
Attached patch Mozbuild.py patch (obsolete) — Splinter Review
Attachment #344313 - Flags: review?(bhearsum)
Comment on attachment 344313 [details] [diff] [review]
Mozbuild.py patch

>--- repo_mozbuild_py	2008-10-22 12:47:06.000000000 -0400
>+++ current_use_mozbuild_py	2008-10-22 13:24:08.000000000 -0400

> MozillaEnvironments['mozbuild'] = {
>+MozillaEnvironments['mozbuild2'] = {
> MozillaEnvironments['mozbuild_pgo'] = {

I realize we're just doing an import, but I would like to know why we have three different environments for windows. Are the slaves not the same? I don't see why PGO should need a different env.

>+class MozillaWinXPMochitest(MozillaMochitest):
>+    command = ['perl runtests.pl --appname=..\\..\\..\\dist\\bin\\firefox.exe --autorun --console-level=INFO --close-when-done']
>+class MozillaWinXPMochichrome(MozillaMochichrome):
>+   command = ['perl runtests.pl --appname=..\\..\\..\\dist\\bin\\firefox.exe --chrome --autorun --console-level=INFO --close-when-done']
>+class MozillaWinXPBrowserChromeTest(MozillaBrowserChromeTest):
>+    command = ['perl runtests.pl --appname=../../../dist/bin/firefox.exe --autorun --browser-chrome --close-when-done']

As discussed on IRC, please remove the WinXP classes (if we need winxp machines again we should probably use runtests.py, anyways).
Attachment #344313 - Flags: review?(bhearsum) → review-
Comment on attachment 344312 [details] [diff] [review]
[checked in] Master.cfg patch

I would really like to unify the win32 environments if there's no useful differences between them. I have a feeling that's not the case though....
Attachment #344312 - Flags: review?(bhearsum) → review+
No more win xp.

I wish we could unify the win32 environments, but the pgo is different than the two non-pgo - they are both DL360's and the pgo is a VM.  

Not sure if it's worth it to replace those with VMs when we are within 6 months of dropping this branch
Attachment #344313 - Attachment is obsolete: true
Attachment #344929 - Flags: review?(bhearsum)
(In reply to comment #4)
> Created an attachment (id=344929) [details]
> Mozbuild.py patch
> 
> No more win xp.
> 
> I wish we could unify the win32 environments, but the pgo is different than the
> two non-pgo - they are both DL360's and the pgo is a VM.  
> 

Well, even with hardware it should be possible to setup hosts with the same PATHs :). If they aren't setup that way I'm not going to make you do it, though.

> Not sure if it's worth it to replace those with VMs when we are within 6 months
> of dropping this branch

It's working as it is, let's not screw with that.
Actually, why is there still mozbuild and mozbuild2? Those slaves aren't the same either?
Attachment #344929 - Flags: review?(bhearsum) → review+
Priority: -- → P2
Attachment #344312 - Attachment description: Master.cfg patch → [checked in] Master.cfg patch
Comment on attachment 344929 [details] [diff] [review]
[checked in] Mozbuild.py patch

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/master.cfg,v  <--  master.cfg
new revision: 1.39; previous revision: 1.38
done
Checking in mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/mozbuild.py,v  <--  mozbuild.py
new revision: 1.25; previous revision: 1.24
done
Attachment #344929 - Attachment description: Mozbuild.py patch → [checked in] Mozbuild.py patch
Closing, the a11y tests are running on Production 1.9 now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.