jsmath.cpp contains stray references to FDLIBM preprocessor symbols

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
x86
Linux
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

10 years ago
Mozilla no longer uses fdlibm, but js/src/jsmath.cpp still contains some references to JS_USE_FDLIBM_MATH.  These should be deleted.
(Assignee)

Comment 1

10 years ago
SpiderMonkey no longer has any reason to use functions whose names begin with fd_, either.
(Assignee)

Comment 2

10 years ago
Created attachment 344364 [details] [diff] [review]
Bug 461192: Remove references to JS_USE_FDLIBM_MATH from js/src/jsmath.cpp.

The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.
Attachment #344364 - Flags: review?(jorendorff)
(Assignee)

Comment 3

10 years ago
Created attachment 344366 [details] [diff] [review]
Bug 461192: Drop fd_ prefix from math functions.

The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.
Attachment #344366 - Flags: review?(jorendorff)
(Assignee)

Comment 4

10 years ago
Created attachment 344367 [details] [diff] [review]
Bug 461192: Rename fd_copysign to js_copysign.

Since we're no longer using fdlibm, it doesn't make sense to use
fd_copysign as the name of SpiderMonkey's appropriately chosen version
of copysign.  js_copysign seems more appropriate.
Attachment #344367 - Flags: review?(jorendorff)
(Assignee)

Comment 5

10 years ago
The Try server likes trunk M-C with the above patches.
Try server changeset 3d11c96c54a6 is trunk 0d405dfa0379 (Wed Oct 22) with those patches applied.  Although the log messages are not right, rats.
Attachment #344364 - Flags: review?(jorendorff) → review+
Attachment #344366 - Flags: review?(jorendorff) → review+
Attachment #344367 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 6

10 years ago
With proper log messages: rev 644b31f76962 from
http://hg.mozilla.org/users/jblandy_mozilla.com/mc-work/
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.