461192 - jsmath.cpp contains stray references to FDLIBM preprocessor symbols

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Mozilla no longer uses fdlibm, but js/src/jsmath.cpp still contains some references to JS_USE_FDLIBM_MATH.  These should be deleted.

Comment 1

[Jim Blandy :jimb]

SpiderMonkey no longer has any reason to use functions whose names begin with fd_, either.

Comment 2

[Jim Blandy :jimb]

Attachment: Bug 461192: Remove references to JS_USE_FDLIBM_MATH from js/src/jsmath.cpp.

The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.

Comment 3

[Jim Blandy :jimb]

Attachment: Bug 461192: Drop fd_ prefix from math functions.

The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.

Comment 4

[Jim Blandy :jimb]

Attachment: Bug 461192: Rename fd_copysign to js_copysign.

Since we're no longer using fdlibm, it doesn't make sense to use
fd_copysign as the name of SpiderMonkey's appropriately chosen version
of copysign.  js_copysign seems more appropriate.

Comment 5

[Jim Blandy :jimb]

The Try server likes trunk M-C with the above patches.
Try server changeset 3d11c96c54a6 is trunk 0d405dfa0379 (Wed Oct 22) with those patches applied.  Although the log messages are not right, rats.

Comment 6

[Jim Blandy :jimb]

With proper log messages: rev 644b31f76962 from
http://hg.mozilla.org/users/jblandy_mozilla.com/mc-work/