Closed Bug 461192 Opened 12 years ago Closed 12 years ago

jsmath.cpp contains stray references to FDLIBM preprocessor symbols

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(3 files)

Mozilla no longer uses fdlibm, but js/src/jsmath.cpp still contains some references to JS_USE_FDLIBM_MATH.  These should be deleted.
SpiderMonkey no longer has any reason to use functions whose names begin with fd_, either.
The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.
Attachment #344364 - Flags: review?(jorendorff)
The Mozilla tree no longer uses fdlibm, so these adaptor macros are no
longer necessary.
Attachment #344366 - Flags: review?(jorendorff)
Since we're no longer using fdlibm, it doesn't make sense to use
fd_copysign as the name of SpiderMonkey's appropriately chosen version
of copysign.  js_copysign seems more appropriate.
Attachment #344367 - Flags: review?(jorendorff)
The Try server likes trunk M-C with the above patches.
Try server changeset 3d11c96c54a6 is trunk 0d405dfa0379 (Wed Oct 22) with those patches applied.  Although the log messages are not right, rats.
Attachment #344364 - Flags: review?(jorendorff) → review+
Attachment #344366 - Flags: review?(jorendorff) → review+
Attachment #344367 - Flags: review?(jorendorff) → review+
With proper log messages: rev 644b31f76962 from
http://hg.mozilla.org/users/jblandy_mozilla.com/mc-work/
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.