MMgc::GCCriticalSection fails to delete acquired critical section

VERIFIED FIXED

Status

Tamarin
Garbage Collection (mmGC)
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Andrew Rahn, Assigned: Tommy Reilly)

Tracking

unspecified
x86
Windows XP
Bug Flags:
flashplayer-triage +

Details

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 2.0.50727)
Build Identifier: Play_10_0_r2_054

There is also a requirement that Critical Sections be properly cleaned up.  We're getting:

"Freeing heap block containing an active critical section"

I see that this class:

            GCCriticalSection()
            {
                  InitializeCriticalSection(&cs);
            }

...also lacks a destructor (w/ a call to the DeleteCriticalSection function).  

Reproducible: Always

Steps to Reproduce:
1. Look at GCCriticalSection
2. Does it call DeleteCriticalSection 
3.
Actual Results:  
No


DeleteCriticalSection is called in teh destructor.
(Assignee)

Updated

10 years ago
Assignee: nobody → treilly
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 1

9 years ago
mark triage+,qrb?
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 2

9 years ago
What's the status on this?  Should this bug be marked as fixed?

Comment 3

9 years ago
(In reply to comment #2)
> What's the status on this?  Should this bug be marked as fixed?

Yeah, it should be fine.  This code has been restructured and every indication is that we delete locks properly.

Updated

9 years ago
Status: RESOLVED → VERIFIED

Updated

9 years ago
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.