use G_TYPE instead of deprecated GTK_ macros in gtkmozembed.h

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
11 years ago
9 months ago

People

(Reporter: asac, Assigned: asac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

When Building epiphany with gecko backend on ubuntu intrepid against a xulrunner 1.9.1 snapshot I noticed that gtkmozembed headers still use the old/deprecated GTK_ macros.

Attaching a patch to convert those to plain G_TYPE macros.
Assignee: nobody → asac
Comment on attachment 344402 [details] [diff] [review]
use G_TYPE macros

Not sure who needs to review this, so tagging both mpgritti and bsmedberg... may the first man win!
Attachment #344402 - Flags: superreview?(benjamin)
Attachment #344402 - Flags: review?(mpgritti)
Is there any reason the G_ form is better than the GTK_ form?
yes, GTK_ macros are deprecated. For instance, with recent gtk+ (as in intrepid), building epiphany with --enable-maintainer-mode gave me compile errors (which is why i considered that it might now be the right time to migrate to the new macros).
Comment on attachment 344402 [details] [diff] [review]
use G_TYPE macros

And here I thought "deprecated" meant things were still usable. Anyhoo.
Attachment #344402 - Flags: superreview?(benjamin) → superreview+
Attachment #344402 - Flags: review?(mpgritti)
Yes, this has been fixed by bug 474116.
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 474116
Resolution: --- → FIXED
comment 6 said "partly" meaning not all bits have been landed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yes, sorry. A search indeed yields some more uses.
gtkxtbin.(c|h) is not built at all, I will file another bug on removing it.
gtkmozembed.h, gtkmozembed_common.h and gtkmozembed_download.h need to be fixed.
/tools/relic/test/relicense_(in|out)puts/no_origcodeis_section.h shouldn't bother us I believe.
Product: Core → Core Graveyard
Embedding: GTK Widget isn't a thing, closing.
Status: REOPENED → RESOLVED
Closed: 11 years ago9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.