The default bug view has changed. See this FAQ.

Drop unnecessary includes from some of Thunderbird's migration code.

RESOLVED FIXED in Thunderbird 3.0b1

Status

Thunderbird
Migration
--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.0b1
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 344474 [details] [diff] [review]
The fix

I wanted to drop the current (unnecessary) nsIPasswordManagerInternal.h includes in mail/components/migration, but then I thought there may be some others, so I did a bit of digging, and removed a few extra.

This is just a very small part of the password manager migration/cleanup.

I've tested it on my mac, and on linux (Linux builds with frozen API in that dir) and it seems to work fine.
Flags: in-testsuite-
Attachment #344474 - Flags: review?(bienvenu)

Comment 1

9 years ago
Comment on attachment 344474 [details] [diff] [review]
The fix

I'm curious why we're still building the dogbert stuff - I believe that's migration from 4.x, and I thought we'd dropped that.
Attachment #344474 - Flags: review?(bienvenu) → review+

Comment 2

9 years ago
I remember that being discussed, but the import wizard still offers it.
(ran into it when running litmus on a3 where it promptly crashed)
(In reply to comment #1)
> (From update of attachment 344474 [details] [diff] [review])
> I'm curious why we're still building the dogbert stuff - I believe that's
> migration from 4.x, and I thought we'd dropped that.

kill 4.x import did not git finished in bug 379068, "Remove support for Netscape 4.x migration from the trunk".  Discussed with bienvenu on IRC that 4.x *import* should indeed be killed.  Do we reopen 379068, or do we handle it in this or a new bug?  Just need to ensure it doesn't impact imports from newer releases. 

(And remove 4.x import from litmus tests.  Check if 6.x and 7.x import is in litmus tests)
(Assignee)

Comment 4

9 years ago
I checked this in a few days ago. Various discussions on import capabilities have been started elsewhere.

http://hg.mozilla.org/comm-central/rev/f9d36b5f01e4
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.