461366 - Don't use -moz-appearance for browser window background, it's not shown anyway

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: patch v1

This might improve drawing performance a little.

Usually the browser background is covered completely by toolbox / tabbrowser / statusbar etc, but when you look at it with QuartzDebug you can see that it's still drawn. A plain background color should be a little faster to draw.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Do we need the background-color at all?

You made the opposite change in bug 431831, do you remember why?

Comment 2

[Markus Stange [:mstange]]

(In reply to comment #1)
> Do we need the background-color at all?

When extensions are involved it's possible that the background-color shows (e.g. behind the Download Statusbar), so I think it makes sense to specify something sane instead of the default white. I don't think it will cost anything.

> You made the opposite change in bug 431831, do you remember why?

Oh, interesting. I hadn't really looked at that patch when I submitted it; it was mostly Kevin's work. I don't know why Kevin chose to make that change.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 344487 [details] [diff] [review]
patch v1

OK, I guess we can just take this on trunk. I'd be wary of taking it on branch at this point though.

Comment 4

[Markus Stange [:mstange]]

pushed: http://hg.mozilla.org/mozilla-central/rev/cfc7b5b533d3

Comment 5

[[e-mail]]

(In reply to comment #1)
> Do we need the background-color at all?
Do you want to trigger translucency ;-)

Comment 6

[Markus Stange [:mstange]]

Mh, apparently the change didn't have any effect on Txul perf.