Closed Bug 461366 Opened 13 years ago Closed 13 years ago

Don't use -moz-appearance for browser window background, it's not shown anyway

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: mstange, Assigned: mstange)

Details

(Keywords: perf)

Attachments

(1 file)

Attached patch patch v1Splinter Review
This might improve drawing performance a little.

Usually the browser background is covered completely by toolbox / tabbrowser / statusbar etc, but when you look at it with QuartzDebug you can see that it's still drawn. A plain background color should be a little faster to draw.
Attachment #344487 - Flags: review?(gavin.sharp)
Do we need the background-color at all?

You made the opposite change in bug 431831, do you remember why?
(In reply to comment #1)
> Do we need the background-color at all?

When extensions are involved it's possible that the background-color shows (e.g. behind the Download Statusbar), so I think it makes sense to specify something sane instead of the default white. I don't think it will cost anything.

> You made the opposite change in bug 431831, do you remember why?

Oh, interesting. I hadn't really looked at that patch when I submitted it; it was mostly Kevin's work. I don't know why Kevin chose to make that change.
Comment on attachment 344487 [details] [diff] [review]
patch v1

OK, I guess we can just take this on trunk. I'd be wary of taking it on branch at this point though.
Attachment #344487 - Flags: review?(gavin.sharp) → review+
pushed: http://hg.mozilla.org/mozilla-central/rev/cfc7b5b533d3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
(In reply to comment #1)
> Do we need the background-color at all?
Do you want to trigger translucency ;-)
Mh, apparently the change didn't have any effect on Txul perf.
You need to log in before you can comment on or make changes to this bug.