Status

Websites
communitystore.mozilla.org
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: rdoherty, Assigned: rdoherty)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Need to slice the design out. Will probably use a dummy html page for basic testing, then integrate into site.
(Assignee)

Comment 1

9 years ago
Created attachment 346341 [details] [diff] [review]
Patch for upload form and various other work

I'm almost finished with the upload form and want some feedback before continuing.

Areas of interest:
-Resizing transparent png. I still can't get this to work. Code is in libs/simpleimage.class.php : resize function
-Upload backend code
-Non-js flow
Attachment #346341 - Flags: review?(buchanae)
Comment on attachment 346341 [details] [diff] [review]
Patch for upload form and various other work

Patch looks good.  A couple notes...

1) There was one typo.  In install.sql, you have `key` but it should be `secret`

2) Currently, _process and _submit don't return true/false, which is needed to show an error page.  I can clean that up after you submit the patch though, just noting it.
Attachment #346341 - Flags: review?(buchanae) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> (From update of attachment 346341 [details] [diff] [review])
> Patch looks good.  A couple notes...
> 
> 1) There was one typo.  In install.sql, you have `key` but it should be
> `secret`
> 
> 2) Currently, _process and _submit don't return true/false, which is needed to
> show an error page.  I can clean that up after you submit the patch though,
> just noting it.

Awesome, thanks! I noticed the key=> secret issue today too. I can also fix the _process and _submit functions.
also, I forgot to note that...

$res = $this->db->query($sql);
(mysqli_num_rows($res) == 1) ? mysqli_fetch_assoc($res) : false;

will throw a warning if the query failed, because mysqli_num_rows() expects a mysqli_result and $res will be false in that case

$res && mysqli_num_rows($res)...

works
(Assignee)

Comment 5

9 years ago
r19688 has the last template work. Anything missing from now on will be a bug.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.