461569 - Add applicationCache.items

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Dave Camp (:dcamp)]

Attachment: v1

The application cache spec replaced applicationCache.length and applicationCache.item(n) with an applicationCache.items that returns a list.

The attached patch adds .items.

We shipped length and item(n) with 3.0, so I didn't remove them in this patch.  It might be worth taking them out now and forcing people to move to .items...

Comment 1

[Boris Zbarsky [:bzbarsky]]

+  if (rv == NS_ERROR_CACHE_KEY_NOT_FOUND ||
+      (types & nsIApplicationCache::ITEM_DYNAMIC) == 0) {
+    *aExists = PR_FALSE;
+    return NS_OK;
+  }

that's testing random data if rv is some other failure, no?

Honza should probably review this too.

Comment 2

[Dave Camp (:dcamp)]

Attachment: fixed up

Fixed up patch.

Comment 3

[Dave Camp (:dcamp)]

Attachment: right version

err, that was the wrong version

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 345618 [details] [diff] [review]
right version

>diff -r 6f766cbdc7ec dom/public/idl/offline/nsIDOMOfflineResourceList.idl
> [scriptable, uuid(c9732cb7-e104-4cf1-9936-a8592fd46c5a)]
> interface nsIDOMOfflineResourceList : nsISupports

Change IID, please.

>
>

In the test you are not testing new hasItem method.

Comment 5

[Dave Camp (:dcamp)]

Attachment: v3

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 345749 [details] [diff] [review]
v3

It would be absolutely perfect to also test that entry that is in the cache but is not dynamic is not visible to hasItem, but this ok.

Comment 7

[Dave Camp (:dcamp)]

http://hg.mozilla.org/mozilla-central/rev/54794163afd4

Comment 8

[gm]

Not working in Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110626 Firefox/7.0a1 ID:20110626030756

console.log(window.applicationCache);
console.log(window.applicationCache.mozItems);

0 items in offline cache
DOMStringList { length=0}

But in "Options > Advanced > Network" my site is listed with 272kb of data.