461594 - Interfaces changed without iid updates

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Dave Townsend [:mossop]]

In my digging and parsing of teh apis I have come across some interfaces that changed between 1.9.0.0 but have not had iid updates. I've filtered out those that are only changes to constants as I understand they are not an issue. Copying those that made the changes, unless there is a reason not to I'll just file a patch to update the iid's for all. All of these were changed between 1.9.0.0 and 1.9.1b1. There have been no changes without iid bumps since.

http://hg.mozilla.org/mozilla-central/diff/553480dceb26/dom/public/idl/html/nsIDOMHTMLCanvasElement.idl
http://hg.mozilla.org/mozilla-central/diff/1ebacbd09ad9/dom/public/idl/base/nsIDOMNavigator.idl
http://hg.mozilla.org/mozilla-central/diff/3e2c3a4d3d40/dom/public/idl/traversal/nsIDOMNodeIterator.idl
http://hg.mozilla.org/mozilla-central/diff/85a89d00d9b3/content/base/public/nsIXMLHttpRequest.idl (nsIJSXMLHttpRequest so maybe not a problem?)
http://hg.mozilla.org/mozilla-central/diff/c823327ec9e0/xpcom/threads/nsIThreadPool.idl
http://hg.mozilla.org/mozilla-central/diff/378495e669f9/widget/src/cocoa/nsPIWidgetCocoa.idl

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

For the Canvas change, I was going to move that to the end of the interface but forgot to do so before checking in.  Updating the IID is fine anyway; there are other additions that have gone in as well (though I think the IID has since been updated for those?).

Comment 2

[Dave Townsend [:mossop]]

Attachment: rev iids

Braindead simple, hardly seems worth reviewing, and I'm not really sure who is right to cover these.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 345560 [details] [diff] [review]
rev iids

vlad said it was ok anyway so just going to land this now.

Comment 4

[Dave Townsend [:mossop]]

Pushed http://hg.mozilla.org/mozilla-central/rev/c45117d60e99