461614 - Can't drag bookmarks in smart collections

Status: RESOLVED WONTFIX

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

1) Select a smart collection, e.g. Address Book
2) Select a bookmark in said collection
3) Attempt to drag selected bookmark

AR: Selection expands in the direction of the drag
ER: Selected bookmark is dragged

I wondered if this was because you can't re-order bookmarks within the smart collections, but you can drag in History and those certainly can't be re-ordered ;)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The culprit seems to be this bit in BookmarkViewController:

> 1478   if ((count == 0) || [mActiveRootCollection isSmartFolder]) // XXX why deny drags from smart folders?
> 1479     return NO;

Why deny drags from smart folders?  At least one reason, apparently, is that we need to make drags from smart folders be copy drags in all/more cases.  

If you fix up that hunk of code to allow smart collection drags, then drags to other collections are treated as pseudo-moves (drags to the location bar and places that treat drags as "url loads" are copies-in-fact, even though they don't all show the copy cursor).

Comment 2

[Chris Lawson (gone)]

Is there a good reason not to remove that part of the conditional? We already have so many copy drags that don't show the copy cursor that it hardly seems like a problem. (What's a pseudo-move? Does the bookmark actually disappear from the smart folder?)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #2)
> Is there a good reason not to remove that part of the conditional?
[...]
> (What's a pseudo-move? Does the bookmark actually disappear
> from the smart folder?)

Yes. It comes back the next time we re-init the collection, but we need to make sure we make smartCollection->collection drags be copies before removing that check.

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]