Closed
Bug 46164
Opened 25 years ago
Closed 25 years ago
Unnecessary code in nsImapServerResponseParser.cpp
Categories
(MailNews Core :: Backend, defect, P3)
MailNews Core
Backend
Tracking
(Not tracked)
VERIFIED
WONTFIX
M18
People
(Reporter: jim_nance, Assigned: Bienvenu)
Details
(Keywords: memory-footprint)
Attachments
(1 file)
In nsImapServerResponseParser.cpp we dynamically allocate an empty
string and then never use it. Its not a big problem, but it is
a bit of bloat. I have attached a patch to fix this.
Updated•25 years ago
|
OS: Linux → All
QA Contact: doronr → BlakeR1234
Comment 2•25 years ago
|
||
should this not go into mailnews backend?
Assignee | ||
Comment 3•25 years ago
|
||
accepting
Assignee | ||
Comment 4•25 years ago
|
||
sorry, we need this code - this code is part of the parsing of a server response
- if you remove this line, it will throw the parser off because we won't be
parsing out part of the response, and will get off by a token, if you know what
I mean.
Comment 5•25 years ago
|
||
Not to be annoying, but...before I verify this, could you explain in a little
more detail what the atDomainList pointer is used for?
Assignee | ||
Comment 6•25 years ago
|
||
well, it's used to free the memory allocated by CreateNilString().
CreateNilString() is used to advance the parser passed the atDomainList.
CreateNilString is a parser routine that reads a string and advances the parser
to the next position in the stream. Note that CreateNilString is a poorly named
routine - it parses any kind of string, including things like NIL, and "foobar".
Updated•20 years ago
|
Product: MailNews → Core
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•