Closed Bug 461754 Opened 11 years ago Closed 11 years ago
Wrong error handling in ns
MIMEInfo Win .cpp
nsMIMEInfoWin.cpp currently has this code: 129 // Returns a value greater than 32 if successful. See msdn. 130 if (result >= 32) The comment is correct, the code isn't. 32 is SE_ERR_DLLNOTFOUND, an error code that is checked later in the switch block. The patch also addresses another small nit: MSDN says the result code of ShellExecute must be cast to an int.
Attachment #344871 - Flags: review?(benjamin)
Thanks. I'm going to be optimistic and assume that I don't need a separate SR for this simple patch and set the checkin-needed keyword.
Comment on attachment 344871 [details] [diff] [review] Fix [Checkin: Comment 2] http://hg.mozilla.org/mozilla-central/rev/0065966a40ac
Attachment #344871 - Attachment description: Fix → Fix [Checkin: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.