461839 - uniscribe breaker on windows mobile

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Doug Turner (:dougt)]

NS_GetComplexLineBreaks requires uniscribe which isn't available on windows mobile.


This patch allows us to build/noop this code.  We may need a real working version.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

any ideas what we should do here?

Comment 3

[Doug Turner (:dougt)]

roc?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You need to do the memset(aBreakBefore, PR_FALSE, aLength) or all kinds of badness will happen.

This line breaking code is only used for Thai, Lao, Khmer and Tibetan currently. So you can probably live without it for a while.

Comment 5

[Doug Turner (:dougt)]

Attachment: patch v.2

i would like to get this patch in, fixing our build bustage.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/988768b8910f

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348580 [details] [diff] [review]
patch v.2

a191=beltzner

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ed8ca5346cee

Comment 9

[Doug Turner (:dougt)]

this landed on the 1.9.1 branch.  adding keyword fixed1.9.1