Closed Bug 461839 Opened 12 years ago Closed 12 years ago

uniscribe breaker on windows mobile

Categories

(Core :: Internationalization, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

NS_GetComplexLineBreaks requires uniscribe which isn't available on windows mobile.


This patch allows us to build/noop this code.  We may need a real working version.
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: smontagu → doug.turner
any ideas what we should do here?
roc?
You need to do the memset(aBreakBefore, PR_FALSE, aLength) or all kinds of badness will happen.

This line breaking code is only used for Thai, Lao, Khmer and Tibetan currently. So you can probably live without it for a while.
Attached patch patch v.2Splinter Review
i would like to get this patch in, fixing our build bustage.
Attachment #344975 - Attachment is obsolete: true
Attachment #348580 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/988768b8910f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #348580 - Flags: approval1.9.1?
Comment on attachment 348580 [details] [diff] [review]
patch v.2

a191=beltzner
Attachment #348580 - Flags: approval1.9.1? → approval1.9.1+
this landed on the 1.9.1 branch.  adding keyword fixed1.9.1
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.