Closed Bug 461856 Opened 13 years ago Closed 13 years ago

No Username on windows mobile.

Categories

(Toolkit :: Startup and Profile System, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

There is no call on windows mobile to get the user name.
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #344989 - Flags: review?(benjamin)
Attachment #344989 - Flags: review?(benjamin) → review+
Comment on attachment 344989 [details] [diff] [review]
patch v.1

This is ok, although I think it would be clearer to write:

#ifdef WINCE
  return NS_ERROR_FAILURE
#else
  ... all the rest
#endif

either way, r=me
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Target Milestone: --- → mozilla1.9.1
Flags: blocking1.9.1+ → blocking1.9.1-
http://hg.mozilla.org/mozilla-central/rev/70097082a265
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #344989 - Flags: approval1.9.1?
Attachment #344989 - Flags: approval1.9.1? → approval1.9.1+
removing blocking flag.  this landed on 1.9.1
Flags: blocking1.9.1-
this landed on the 1.9.1 branch.  adding keyword fixed1.9.1
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.